Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all members of utils.helpers to more descriptive locations and either make public or make part of individual modules #4330

Merged
merged 29 commits into from
Jul 1, 2022
Merged

Move all members of utils.helpers to more descriptive locations and either make public or make part of individual modules #4330

merged 29 commits into from
Jul 1, 2022

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jun 30, 2022 •
edited
Loading

  • Move create_on_off_val ... to its own submodule and make public
  • Move path helpers to their own module and rework to use importlib_resources rathat than importing qcodes
  • Move abstract_method to its own submodule and rename so its more obvious that this is not the std lib abstract decorator

@codecov
Copy link

codecov bot commented Jun 30, 2022 •
edited
Loading

Codecov Report

Merging #4330 (e87c0cf) into master (cda680b) will decrease coverage by 0.08%.
The diff coverage is 78.68%.

@@            Coverage Diff             @@
##           master    #4330      +/-   ##
==========================================
- Coverage   68.46%   68.37%   -0.09%     
==========================================
  Files         255      267      +12     
  Lines       30974    30961      -13     
==========================================
- Hits        21205    21170      -35     
- Misses       9769     9791      +22

@jenshnielsen jenshnielsen changed the title [Wip] Refactor remaining helpers api API: helpers move create_on_off... path helpers and abstract methods to their own submodules and document at top level Jun 30, 2022
@jenshnielsen jenshnielsen marked this pull request as ready for review June 30, 2022 07:55
astafan8
astafan8 approved these changes Jun 30, 2022
View reviewed changes
@jenshnielsen jenshnielsen marked this pull request as draft June 30, 2022 08:57
astafan8
astafan8 reviewed Jun 30, 2022
View reviewed changes
@jenshnielsen jenshnielsen force-pushed the api/helpers branch 2 times, most recently from f1cf8f7 to e060739 Compare June 30, 2022 12:27
@jenshnielsen jenshnielsen changed the title API: helpers move create_on_off... path helpers and abstract methods to their own submodules and document at top level Move all members of utils.helpers to more descriptive locations and either make public or make part of individual modules Jun 30, 2022
@jenshnielsen jenshnielsen marked this pull request as ready for review June 30, 2022 12:38
@jenshnielsen jenshnielsen requested a review from astafan8 June 30, 2022 12:56
@jenshnielsen
Copy link
Collaborator Author

@astafan8 Adapted this to cleanup all of helpers, could you have another look

@jenshnielsen jenshnielsen mentioned this pull request Jun 30, 2022
Merged
astafan8
astafan8 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work! looks great now :)

@jenshnielsen
Copy link
Collaborator Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 1, 2022

Build succeeded:

@bors bors bot merged commit 29b1aaf into microsoft:master Jul 1, 2022
@jenshnielsen jenshnielsen deleted the api/helpers branch July 1, 2022 12:22
@jenshnielsen jenshnielsen mentioned this pull request Jul 5, 2022
Merged
bors bot added a commit that referenced this pull request Jul 5, 2022
@bors @jenshnielsen
Merge #4355 #4358
00b6bfa 
4355: API: Split metadata module and make public r=jenshnielsen a=jenshnielsen

Move functions that need to know about dataset to that module
and extend with a function that takes dataset rather than runid

Split Metadatable class and shapshot diff functions into different
submodules and make all public


4358: Remove deprecated units from data array r=jenshnielsen a=jenshnielsen

This was missed as part of #4330 

Co-authored-by: Jens H. Nielsen <[email protected]>
Co-authored-by: Jens Hedegaard Nielsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenshnielsen @astafan8