Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/spaceship: Merge Standard_D16as_v4 VM update #1188

Merged
merged 8 commits into from
Aug 12, 2020

Conversation

StephanTLavavej
Copy link
Member

Merge #1185 into feature/spaceship so we can delete the old VMSS pool.

⚠️ Note to self: Commit this as a merge, not a squash!

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Aug 12, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 12, 2020 22:05
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the list of commits; here's hoping you didn't hack up an artificial parallel git history.

EDIT: I felt bad, and actually verified the changes ;)

@StephanTLavavej
Copy link
Member Author

@CaseyCarter Note that for #1178, I had to prepare a branch in my fork to perform the merge and manually resolve a merge conflict, but for this PR, I was able to submit a merge directly from master to feature/spaceship. In the future, you may be able to save time by noticing non-fork PRs like this, while double-checking any merges from forks (as manual merges make mistakes more likely). Thanks for checking!

@StephanTLavavej StephanTLavavej added the uncharted Excluded from the Status Chart label Aug 12, 2020
@StephanTLavavej StephanTLavavej merged commit 98c4f96 into feature/spaceship Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation uncharted Excluded from the Status Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants