Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/spaceship: Merge fix for test timing assumption #1212

Merged
merged 10 commits into from
Aug 20, 2020

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Aug 20, 2020

Merge master into feature/spaceship to pick up #1193 and prevent sporadic test failures.

⚠️ Note to self: Commit this as a merge, not a squash!

AlexGuteniev and others added 10 commits August 12, 2020 18:10
Co-authored-by: Billy O'Neal <[email protected]>
Co-authored-by: Adam Bucior <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: S. B. Tam <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Casey Carter <[email protected]>
So our test coverage won't be damaged when the compiler changes `/std:c++latest` to imply `/permissive-`. I do so by adding `/permissive-` to every `/std:c++latest` command line that doesn't yet have it, and then reverting one configuration in each matrix to `/permissive`. It seems sensible to me that the majority of our coverage should change from permissive to strict mode to reflect the change in compiler default.
Resolves #1120.

Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Casey Carter <[email protected]>
@StephanTLavavej StephanTLavavej added test Related to test code uncharted Excluded from the Status Chart labels Aug 20, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 20, 2020 00:50
@StephanTLavavej StephanTLavavej merged commit b9642bf into feature/spaceship Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code uncharted Excluded from the Status Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants