Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2019 16.9 Preview 3 #1577

Merged
merged 14 commits into from
Jan 22, 2021

Conversation

StephanTLavavej
Copy link
Member

  • azure-devops/provision-image.ps1
    • Obtain PsExec64.exe by downloading and extracting PSTools.zip, which is apparently recommended over directly downloading the executable.
    • Download and extract PowerShell 7.1.1 so we can pass -UseMinimalHeader to Start-Transcript, which reduces log verbosity.
    • Centralize common machinery in Function DownloadAndExtractZip.
    • Redact the AdminUserPassword when printing logs.
    • PsExec now requires the -i option when using -h. (Without it, the script fails with a difficult-to-understand error.)
    • Cleanup the extracted ZIP directories.
    • Update to Python 3.9.1.
    • Now that we're running in interactive mode, pip install prints useful information in the transcript (yay) but also a noisy progress bar that does us no good (because we only see the transcript when everything is done). So, run pip install with --progress-bar off.
    • Use bcdedit to enable test-signed kernel-mode drivers. (Works towards Kernel mode test harness #1421, untested here.)
  • azure-devops/create-vmss.ps1
    • Set SuppressAzurePowerShellBreakingChangeWarnings; this noise has never been useful to us.
  • README.md
    • Update VS, CMake, Ninja, Python versions. (CMake and Ninja were updated in Preview 3.)
  • CMakeLists.txt
    • Require CMake 3.19. (We don't need anything from it yet - this is just the general principle of minimizing our support matrix.)
  • azure-pipelines.yml
    • Use the new VMSS pool.
  • tests/std/tests/P0220R1_optional/test.cpp
    • Work around (Microsoft-internal bug) VSO-1268140 "EDG: weirdness evaluating rvalue-qualified constexpr member function", reduced and reported by @CaseyCarter.

@StephanTLavavej StephanTLavavej added high priority Important! infrastructure Related to repository automation labels Jan 21, 2021
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner January 21, 2021 08:10
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Important! infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants