Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/spaceship: Clause 26: Numerics #1627

Merged
merged 12 commits into from
Feb 12, 2021
Merged

feature/spaceship: Clause 26: Numerics #1627

merged 12 commits into from
Feb 12, 2021

Conversation

AnjuDel
Copy link
Member

@AnjuDel AnjuDel commented Feb 5, 2021 •
edited by StephanTLavavej
Loading

Works towards #62.

@CaseyCarter CaseyCarter added cxx20 C++20 feature spaceship C++20 operator <=> labels Feb 5, 2021
@StephanTLavavej StephanTLavavej changed the title added spaceship slice feature/spaceship: Clause 26: Numerics Feb 5, 2021
StephanTLavavej
StephanTLavavej requested changes Feb 5, 2021
View reviewed changes
stl/inc/valarray Outdated Show resolved Hide resolved
stl/inc/complex Outdated Show resolved Hide resolved
stl/inc/valarray Show resolved Hide resolved
stl/inc/valarray Outdated Show resolved Hide resolved
stl/inc/valarray Outdated Show resolved Hide resolved
tests/std/tests/P1614R2_spaceship/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1614R2_spaceship/test.cpp Show resolved Hide resolved
tests/std/tests/P1614R2_spaceship/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1614R2_spaceship/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1614R2_spaceship/test.cpp Outdated Show resolved Hide resolved
@statementreply statementreply mentioned this pull request Feb 6, 2021
Open
StephanTLavavej
StephanTLavavej requested changes Feb 10, 2021
View reviewed changes
stl/inc/valarray Outdated Show resolved Hide resolved
tests/std/tests/P1614R2_spaceship/test.cpp Outdated Show resolved Hide resolved
Anju del Moral Gonzalez and others added 3 commits February 10, 2021 15:14
@AnjuDel AnjuDel marked this pull request as ready for review February 11, 2021 20:46
@AnjuDel AnjuDel requested a review from a team as a code owner February 11, 2021 20:46
StephanTLavavej
StephanTLavavej approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! I've pushed changes for two stylistic issues:

  • Change the #endif comment in <valarray> to match the #if there.
  • In the test, directly construct std::slice a1(2, 3, 4); instead of constructing a temporary. Both are correct, but direct construction avoids repeating the type name.

@StephanTLavavej StephanTLavavej mentioned this pull request Feb 12, 2021
Closed
@StephanTLavavej StephanTLavavej merged commit 5443c4a into microsoft:feature/spaceship Feb 12, 2021
@StephanTLavavej
Copy link
Member

Congratulations on your first microsoft/STL commit! 🎉 😸 🛸

@AnjuDel
Copy link
Member Author

AnjuDel commented Feb 12, 2021

Congratulations on your first microsoft/STL commit! 🎉 😸 🛸

Thanks STL 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@statementreply statementreply statementreply requested changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
cxx20 C++20 feature spaceship C++20 operator <=>
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnjuDel @StephanTLavavej @statementreply @CaseyCarter