Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/spaceship: Clause 20: variant, monostate #1657

Merged
merged 6 commits into from
Feb 19, 2021
Merged

feature/spaceship: Clause 20: variant, monostate #1657

merged 6 commits into from
Feb 19, 2021

Conversation

d-winsor
Copy link
Contributor

No description provided.

@StephanTLavavej StephanTLavavej added cxx20 C++20 feature spaceship C++20 operator <=> labels Feb 17, 2021
CaseyCarter
CaseyCarter suggested changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky things. High-level approach is great.

stl/inc/variant Outdated Show resolved Hide resolved
stl/inc/variant Show resolved Hide resolved
stl/inc/variant Outdated Show resolved Hide resolved
stl/inc/variant Outdated Show resolved Hide resolved
stl/inc/variant Outdated Show resolved Hide resolved
stl/inc/variant Show resolved Hide resolved
tests/std/tests/P1614R2_spaceship/test.cpp Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter self-assigned this Feb 17, 2021
@d-winsor d-winsor marked this pull request as ready for review February 18, 2021 18:44
@d-winsor d-winsor requested a review from a team as a code owner February 18, 2021 18:44
miscco
miscco approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

stl/inc/variant Show resolved Hide resolved
CaseyCarter
CaseyCarter suggested changes Feb 18, 2021
View reviewed changes
stl/inc/variant Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter removed their assignment Feb 18, 2021
StephanTLavavej
StephanTLavavej reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'll add a commit to enhance the test coverage.

tests/std/tests/P1614R2_spaceship/test.cpp Show resolved Hide resolved
tests/std/tests/P1614R2_spaceship/test.cpp Show resolved Hide resolved
tests/std/tests/P1614R2_spaceship/test.cpp Show resolved Hide resolved
@StephanTLavavej StephanTLavavej changed the title Spaceship operator for variant feature/spaceship: Clause 20: variant, monostate Feb 19, 2021
@StephanTLavavej StephanTLavavej merged commit 55c2af9 into microsoft:feature/spaceship Feb 19, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing one of C++20's most complicated spaceships (and its least complicated! 😹) and congratulations on your first microsoft/STL commit! 🎉 🚀 🛸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees
No one assigned
Labels
cxx20 C++20 feature spaceship C++20 operator <=>
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-winsor @StephanTLavavej @CaseyCarter @miscco