Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of locale in chrono formatters #1892

Closed
wants to merge 6 commits into from
Closed

Fix handling of locale in chrono formatters #1892

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6964586
Fix handling of locale in chrono formatters
vitaut May 1, 2021
366cef0
Add the 'L' specifier to chrono formatter
vitaut May 1, 2021
fdbfb0f
Add a test for localized chrono formatting
vitaut May 2, 2021
1b50d8c
Use dash in locale name for compatibility with old systems
vitaut May 2, 2021
05c15b6
ABI mitigation, drop std:: and auto
vitaut May 3, 2021
2ff83c7
Keep ostream insertion operators localized
vitaut May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stl/inc/chrono
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5272,6 +5272,7 @@ struct _Chrono_format_specs {
int _Dynamic_precision_index = -1;
_Fmt_align _Alignment = _Fmt_align::_None;
uint8_t _Fill_length = 1;
bool _Localized = false;
// At most one codepoint (so one char32_t or four utf-8 char8_t)
_CharT _Fill[4 / sizeof(_CharT)] = {_CharT{' '}};
// recursive definition in grammar, so could have any number of these
Expand Down Expand Up @@ -5935,7 +5936,7 @@ namespace chrono {
if (_Specs._Chrono_specs_list.empty()) {
_Stream << _Val; // N4885 [time.format]/6
} else {
_Stream.imbue(_FormatCtx.locale());
_Stream.imbue(_Specs._Localized ? _FormatCtx.locale() : std::locale::classic());
if constexpr (_Is_specialization_v<_Ty, hh_mm_ss>) {
if (_Val.is_negative()) {
_Stream << _CharT{'-'};
Expand Down