Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: remove unneeded [[maybe_unused]] annotations #920

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented Jun 25, 2020

... from variables that are used only on some if constexpr branches. I suspect Stephan missed a couple of these in his prior pass that was looking for (void) meow. (And I added a couple of them after 😢 )

... from variables that are used only on some `if constexpr` branches.
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Jun 25, 2020
@CaseyCarter CaseyCarter marked this pull request as ready for review June 25, 2020 17:22
@CaseyCarter CaseyCarter requested a review from a team as a code owner June 25, 2020 17:22
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The explanation is simpler - I didn't think to scan for these attributes at all.

@CaseyCarter CaseyCarter merged commit 3f6c715 into microsoft:master Jun 30, 2020
@CaseyCarter CaseyCarter deleted the maybe_unused branch June 30, 2020 05:42
@CaseyCarter CaseyCarter removed their assignment Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants