Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Do's and Don'ts Use Optional Parameters section slightly unclear #420

Closed
agrberg opened this issue Oct 19, 2016 · 0 comments
Closed

Do's and Don'ts Use Optional Parameters section slightly unclear #420

agrberg opened this issue Oct 19, 2016 · 0 comments

Comments

@agrberg
Copy link
Contributor

agrberg commented Oct 19, 2016

This section has a more complicated example than necessary which distracts from the core issue being presented. I will submit a PR shortly to address this. Please see this gist for more details.

alexinea added a commit to dotnetcore-internal/TypeScript-Handbook that referenced this issue Dec 29, 2016
* Add release notes

* Remove headers

* Add links to documentation for @types, --types and --typeRoots

Referenced in microsoft/TypeScript#11437 (comment)

* Update Compiler Options.md

Fix minor typo.

* Mention Babel at top of Gulp tutorial.

* IntelliJ Mac for nightly builds

Maybe include IntelliJ IDEA IDE for mac, too?

* Updated whitespaces and empty lines

* Use 'awesome-typescript-loader', use SFCs.

* Mentioned support for --outFile together with AMD or System

* Fixed broken link in React Webpack tutorial

 Updated the path reference to the page about tsconfig.json as it was broken.

* Fixes microsoft#420

clarifies Do's and Don'ts Use Optional Parameters section

See https://gist.github.com/agrberg/7bf64c61d3c6de0c638e7c0bc4742000 for
more details

* Change </br> to <br/>

* Fix microsoft/TypeScript#10433

* Fix microsoft/vscode#14322

* Fix paths example: target should be "jquery", not "jquery.d.ts"

Also add missing closing braces and have all json consistently use 2 space indents.

* Port fix in microsoft#432

* Fix lint failure

* Fixed typo

* Invoke origin setter in Decorators.md

* Add object rest/spread

* Update compiler options for TS 2.1

* Review comments

* Fix microsoft#348

* Review comments

* Add TypeScript 2.1 release notes

* Reorder

* Fix typo

* Minor typo

* Document index and indexed access types

* Document mapped types

* Reword and reorder index types discussion

* Fix module import

* Grammar fix

* Review comments

* Simplify keyof

* Fix typos

* Reorder mapped types example

Based on the more involved discussion from the blog post.

* Minor edits from PR comments

* Discuss mapped type inference and call out terms better

* Move index and map types to end of Advanced Types

The feature depends on type aliases and string literal types, so
should come after those.

* Document [non-]nullable types

* Does not require `this.` before props in the stateless functional component example

* `Hello` must be exported to be used in `index.tsx`

* Removed typo square bracket

* Minor formatting tweak from PR comments

* Mention there are currently 2 webpack loaders for typescript and link to more information

Fixes microsoft#450

* Fix defaults for `--importHelpers`

* Add breaking change link to release-notes

* Fix typo in variable reference

* Fix two small errors in React + Webpack tutorial.

* fixing #12872, add a mistype to show the usage of optional properties

* Fix typos

* Change the phrasing on webpack typescript loaders to be more clear

* Update Interfaces.md

* Update Interfaces.md

* limit files to just the src directory

* Update 'include' in React guide.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant