Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja translation] playground-example/4-0 #1397

Merged
merged 3 commits into from
Jan 4, 2021

Conversation

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2020

Thanks for the PR!

This section of the codebase is owned by @sasurau4, @Quramy, @Naturalclar, and @Takepepe - if they write a comment saying "LGTM" then it will be merged.

Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 一旦、Named Tuplesまで見ました

@@ -0,0 +1,41 @@
// 論理代入演算子は、

This comment was marked as resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

論理和代入は||=を指しますが、ここは複数形なので、
||=/&&=/??=のグループのことだと思います。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

たしかに!

Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見ました!

@uraway
Copy link
Contributor Author

uraway commented Dec 9, 2020

ありがとうございます!

Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@uraway
Copy link
Contributor Author

uraway commented Jan 4, 2021

codebase owner merger doesn't work?

@orta
Copy link
Contributor

orta commented Jan 4, 2021

interesting, let's merge it either way

@orta orta merged commit beca34a into microsoft:v2 Jan 4, 2021
@uraway uraway deleted the feature/translation-4-0 branch January 8, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants