-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja translation] playground-example/4-0 #1397
Conversation
Thanks for the PR! This section of the codebase is owned by @sasurau4, @Quramy, @Naturalclar, and @Takepepe - if they write a comment saying "LGTM" then it will be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 一旦、Named Tuplesまで見ました
packages/playground-examples/copy/ja/4-0/New JS Features/JSDoc Deprecated.ts
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,41 @@ | |||
// 論理代入演算子は、 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
論理和代入は||=
を指しますが、ここは複数形なので、
||=
/&&=
/??=
のグループのことだと思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
たしかに!
packages/playground-examples/copy/ja/4-0/New JS Features/Logical Operators and Assignment.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/ja/4-0/New JS Features/Logical Operators and Assignment.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/ja/4-0/New JS Features/Logical Operators and Assignment.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/ja/4-0/New JS Features/Nullish Coalescing.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/ja/4-0/New TS Features/Named Tuples.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
見ました!
packages/playground-examples/copy/ja/4-0/New TS Features/Variadic Tuples.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/ja/4-0/New TS Features/Variadic Tuples.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daiki Ihara <[email protected]>
ありがとうございます! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
codebase owner merger doesn't work? |
interesting, let's merge it either way |
ref: #220
original files:
diff: 26b4f0d