Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate allowJs, checkJs, jsx, declaration, declarationMap, and sourcemap options into Japanese #261

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Translate allowJs, checkJs, jsx, declaration, declarationMap, and sourcemap options into Japanese #261

merged 4 commits into from
Feb 19, 2020

Conversation

Quramy
Copy link
Contributor

@Quramy Quramy commented Feb 17, 2020 •
edited
Loading

@Quramy Quramy requested a review from orta as a code owner February 17, 2020 06:51
@Quramy Quramy force-pushed the i18n-jp-tsconfig-js-and-map-options branch from 74b87e0 to ccd0759 Compare February 17, 2020 07:01
Naturalclar
Naturalclar approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的に読みやすいと感じました！ LGTM

@orta orta merged commit 8bcdcf9 into microsoft:v2 Feb 19, 2020
@Quramy Quramy deleted the i18n-jp-tsconfig-js-and-map-options branch February 19, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

@orta orta Awaiting requested review from orta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quramy @Naturalclar @orta