Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate project options about code emission #281

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

Quramy
Copy link
Contributor

@Quramy Quramy commented Feb 24, 2020

@Quramy Quramy requested a review from orta as a code owner February 24, 2020 09:12
export const helloWorldPTBR = "Olá Mundo";
```

`removeComments`が`true`であるとき、次のようになります:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この説明部分、最初原文がおかしかったので #275 で原文側をfixしています(最新のv2には反映されてますが念の為)。

Copy link
Contributor

@takefumi-yoshii takefumi-yoshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

概ねよさそうです! LGTM //

@orta
Copy link
Contributor

orta commented Feb 25, 2020

👍

@orta orta merged commit c0777f8 into microsoft:v2 Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants