Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate tsconfig options about moduleResolution into ja #289

Merged
merged 5 commits into from
Mar 2, 2020

Conversation

Quramy
Copy link
Contributor

@Quramy Quramy commented Feb 26, 2020

A part of #220. I translated tsconfig docs under moudleResolution section ( https://www.typescriptlang.org/v2/en/tsconfig#Module_Resolution_Options_6174 )

@Quramy Quramy requested a review from orta as a code owner February 26, 2020 10:11
@orta
Copy link
Contributor

orta commented Feb 26, 2020

I'd recommend translating the oneline: at the top, they show up in the playground and could be used in a few other places later 👍🏾

( it might be easier to just do them all at the end though, which is how I did it )

3 similar comments
@orta
Copy link
Contributor

orta commented Feb 26, 2020

I'd recommend translating the oneline: at the top, they show up in the playground and could be used in a few other places later 👍🏾

( it might be easier to just do them all at the end though, which is how I did it )

@orta
Copy link
Contributor

orta commented Feb 26, 2020

I'd recommend translating the oneline: at the top, they show up in the playground and could be used in a few other places later 👍🏾

( it might be easier to just do them all at the end though, which is how I did it )

@orta
Copy link
Contributor

orta commented Feb 26, 2020

I'd recommend translating the oneline: at the top, they show up in the playground and could be used in a few other places later 👍🏾

( it might be easier to just do them all at the end though, which is how I did it )

@orta
Copy link
Contributor

orta commented Feb 26, 2020

Thanks GitHub

@Quramy
Copy link
Contributor Author

Quramy commented Feb 26, 2020

they show up in the playground and could be used in a few other places later 👍🏾

Thanks, I got it! I will translate them all at the end.

---

デフォルトでは、_表示されている_すべての"`@types`"パッケージがコンパイル時にインクルードされます。
囲まれている任意のフォルダの`node_modules/@types`内のパッケージが_表示されている_とみなされます。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO: enclosingがうまく訳せないので、任意のだけで良さそう

Suggested change
囲まれている任意のフォルダの`node_modules/@types`内のパッケージが_表示されている_とみなされます。
任意のフォルダの`node_modules/@types`内のパッケージが_表示されている_とみなされます。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enclosingがうまく訳せないからといって消していいものではないと思います。例えば下記のfile treeについて、"enclosing"をなくして「任意のnode_modules」としてしまうと、A, B, Cのすべてが対象になってしまいませんか?

  • root/prj/tsconfig.json
  • root/prj/hoge/node_modules A (<-- これは対象外のはず
  • root/prj/node_modules B
  • root/node_modules C

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

意訳するのであれば、「プロジェクトを囲んでいる任意のフォルダの〜」とかですかね?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

完全にAも含まれると読み違えてました
Node.jsと同じ挙動だよってことですね
https://nodejs.org/dist/latest-v13.x/docs/api/modules.html#modules_loading_from_node_modules_folders

良い訳が思いつかなかったので、Googleしたら、MacのFinder->Goに「Enclosing Folder」ってのがあって、日本語だと「内包しているフォルダ」でした
参考までに。。。
移動_と_Menubar

---

デフォルトでは、すべての_表示されている_"`@types`"パッケージがコンパイル時にインクルードされます。
囲まれている任意のフォルダの`node_modules/@types`内のパッケージが_表示されている_とみなされます。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO: enclosingがうまく訳せないので、任意のだけで良さそう

Suggested change
囲まれている任意のフォルダの`node_modules/@types`内のパッケージが_表示されている_とみなされます。
任意のフォルダの`node_modules/@types`内のパッケージが_表示されている_とみなされます。

Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@orta orta merged commit 76f8f80 into microsoft:v2 Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants