Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Primitives "Union and Intersection Types" of playground examples into Japanese #295

Conversation

takefumi-yoshii
Copy link
Contributor

Overview

I translated Primitives "Union and Intersection Types" playground-example.
part of #220

@Quramy
Copy link
Contributor

Quramy commented Feb 27, 2020

2行だけコメント書きました。他はLGTMです 😄

原文 / 訳文のcompareリンク、とても見やすくて助かりました!

@orta
Copy link
Contributor

orta commented Feb 27, 2020

( The CI can be ignored, GitHub is having issues )

Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Quramy さんと同じところと別で1箇所だけコメントしました
原文のdiffめっちゃ見やすくてありがたいです 👍

takefumi-yoshii and others added 3 commits February 28, 2020 20:58
Co-Authored-By: Yosuke Kurami <[email protected]>
Co-Authored-By: Yosuke Kurami <[email protected]>
Co-Authored-By: Daiki Ihara <[email protected]>
@Quramy
Copy link
Contributor

Quramy commented Feb 29, 2020

LGTM

@orta orta merged commit 884d80c into microsoft:v2 Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants