Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate/some options into ja 2 #314

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Translate/some options into ja 2 #314

merged 3 commits into from
Mar 10, 2020
+82 −0

Conversation

sasurau4
Copy link
Contributor

@sasurau4 sasurau4 commented Mar 6, 2020

Overview

part of #220

comparison to original docs: f1f5a9e
original docs: https://www.typescriptlang.org/v2/en/tsconfig#disableSizeLimit

@sasurau4 sasurau4 requested a review from orta as a code owner March 6, 2020 05:10
@Quramy
Copy link
Contributor

Quramy commented Mar 6, 2020

文章はLGTMですが、一点だけnitな指摘しましたー

Quramy
Quramy approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@Quramy Quramy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orta orta merged commit 864f2a6 into microsoft:v2 Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quramy Quramy Quramy approved these changes

@orta orta Awaiting requested review from orta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sasurau4 @Quramy @orta