Translate advanced tsconfig options(jsxFactory ~ stripInternal) into Japanese #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quramy
commented
Mar 6, 2020
| @@ -5,5 +5,5 @@ oneline: "Skip ahead-of-time checking for import and <reference files" | |||
|
|
|||
| By default, TypeScript will examine the initial set of files for `import` and `<reference` directives and add these resolved files to your program. | |||
|
|
|||
| If `noResolve` isn't set, this process doesn't happen. | |||
There was a problem hiding this comment.
It seemed wrong and I fixed.
sasurau4
reviewed
Mar 7, 2020
| oneline: "Include a byte order mark to output files" | ||
| --- | ||
|
|
||
| TypeScriptがファイルを書き込むときに[バイトオーダーマーク（BOM）](https://en.wikipedia.org/wiki/Byte_order_mark)を出力するかどうかを制御します。 |
There was a problem hiding this comment.
wikiのLINKを日本語版にするか悩みますね
とりあえず、enで良さそう
There was a problem hiding this comment.
他でもいくつか外部リンク先で en or ja選択できるとこ（MDNとか）がありましたが、enにしてます。
| --- | ||
|
|
||
| ファイルを出力するときの改行コードを指定します: 'CRLF'（dos）または'LF'（unix）のいずれかを指定してください。 | ||
|
|
There was a problem hiding this comment.
newLineですから！
というのはさておき、直します 🙇
packages/tsconfig-reference/copy/ja/options/noErrorTruncation.md
Outdated
Show resolved
Hide resolved
| propertyWithAnExceedinglyLongName5: string; | ||
| }; | ||
|
|
||
| // 型'x'の文字列表現はエラメッセージ中で省略されます |
There was a problem hiding this comment.
英語の原文が間違ってる気がします。
95b0a2e#r37689740
There was a problem hiding this comment.
確かに、、、と思うものの、 #315 (comment) とのことだし、一旦このPRでどうこうするのはやめておこうかと。
|
Yeah, so I'm really not sure if that compiler flag works or if my somehow my implementation is broken TBH I took the code from the test suite in the codebase - might be worth me dropping it completely. |
Co-Authored-By: Daiki Ihara <[email protected]>
|
@orta Thanks LGTM 👍 |
|
CI fail is my fault! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #220 .
I translated tsconfig options from https://www.typescriptlang.org/v2/en/tsconfig#jsxFactory to https://www.typescriptlang.org/v2/en/tsconfig#stripInternal .
Comparison from the original docs: 95b0a2e