Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-do the esmoduleinterop docs #873

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Re-do the esmoduleinterop docs #873

merged 2 commits into from
Aug 7, 2020

Conversation

orta
Copy link
Contributor

@orta orta commented Aug 7, 2020

I think they weren't clear enough, and I had mixed some of allowSyntheticDefaultImport's docs in there

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2020

Messages
📖

Deployed to a PR branch - playground tsconfig old handbook

Got false positives?

Make changes to the global settings spellcheck.json in /artsy/peril-settings.

Typos for esModuleInterop.md

Line Typo
6 or not set) TypeScript treats CommonJS/AMD/UMD modules similar to ES
12 This mis-match causes these two issues:
14 - the ES6 modules spec states that a namespace impor
15 be callable. This breaks the spec's recommendations.
17 e accurate to the ES6 modules spec, most libraries with CommonJS
17 les spec, most libraries with CommonJS/AMD/UMD modules didn't confor
19 Script. The first changes the behavior in the compiler,the second is

Typos for allowSyntheticDefaultImports.md

Line Typo
56 This option brings the behavior of TypeScript in-line with Ba

Generated by 🚫 dangerJS against 2e3a872

@orta orta mentioned this pull request Aug 7, 2020
12 tasks
@orta
Copy link
Contributor Author

orta commented Aug 7, 2020

I'm happy that this is an improvement, open to feedback and I can edit the docs in a new PR

@orta orta merged commit e244cf8 into v2 Aug 7, 2020
@jakebailey jakebailey deleted the esmoduleint_docs branch May 17, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant