Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify analyzer instructions in wiki #342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maschwenk
Copy link

It feels like these are simpler instructions and is less stateful

@jakebailey
Copy link
Member

The package has more than one binary, though.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jan 6, 2025

The original instructions could probably use --no-save though. We'd be willing to take a PR for that.

@maschwenk
Copy link
Author

@DanielRosenwasser / @jakebailey 😆 I swear I ran this locally and this worked. There must be some kind of default behavior when there are multiple binaries. Regardless, we can get around that with:

npx --package=@typescript/analyze-trace analyze-trace

but happy to do the --no-save option too!

@jakebailey
Copy link
Member

It definitely works, but only for analyze-trace because it happens to be first. I'm not sure that's a great thing, but I mean it's probably ok in this specific guide.

@maschwenk
Copy link
Author

@jakebailey for sure, I don't like the feeling of relying on some default behavior where it picks arbitrarily based on alphasort. But my recommendation here should sidestep that:

npx --package=@typescript/analyze-trace analyze-trace

--package is what allows you to disambiguate the package name from the binary name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants