-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSServer maximum call stack crash #34726
Comments
I can't repro this in emacs, and the stack looks very strange -- not particularly related to getCodeFixes. @sheetalkamat mind taking a look at this? |
Doesn't seem to repro for me.. tried vscode as well as insiders build |
Now I can't repo this either. Not sure if my project was in a bad state or what but I'll reopen if I see this again |
Seeing this again with 3.8.0-dev.20191102. Repo:
TS Server log:
|
@typescript-bot cherry-pick this to release-3.7 |
Component commits: dfa4bc0 Use empty object for invalid package json contents instead of undefined Fixes microsoft#34726 4d035ba Behave as if package json doesnt exist in case of invalid json in package json
TypeScript Version: 3.7.1-rc
Search Terms:
Repo
extension.ts
: https://github.com/microsoft/vscode/blob/ecdba243ff6a17d1c274a916839ca991f0c36bc0/extensions/markdown-language-features/src/extension.ts#L48new MarkdownPreview()
MarkdownPreview
. This should show an auto importBug:
The text was updated successfully, but these errors were encountered: