Ensure transformFlags are correct before visiting a node. #12039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transforming a
SpreadElementExpression
in aCallExpression
, we callcreateCallBinding
which may return a new expression containing an existing subtree. However, this new expression has not had its transform flags computed. Then, when we go to visit the target, our visitor thinks there is nothing to do since no flags are set. To fix this, and catch any future instances of this issue, we will now callaggregateTransformFlags
prior to visiting any node to ensure the flags are computed.Fixes #12010