Accept Iterable|ArrayLike union in Array.from, add tests #20467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jessidhia
commented
Dec 5, 2017
|
|
||
| const result1: A[] = Array.from(inputA); | ||
| const result2: A[] = Array.from(inputA.values()); | ||
| const result3: B[] = Array.from(inputA.values()); // expect error |
There was a problem hiding this comment.
This would not error out if mapfn was optional instead of an extra parameter in an overload
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20432, and adds extra tests for #19682. The PR at #19693 that initially closed #19682 accidentally also fixed the incorrect inference that was making the
// expect errorcases not error.