getEditsForFileRename: Test both before and after the rename #25074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
getEditsForFileRename_testBothWays
branch
from
ae7e48a to
f2bbb3a
Compare
ghost
force-pushed
the
getEditsForFileRename_testBothWays
branch
from
f2bbb3a to
a5a0676
Compare
mhegazy
reviewed
Jun 21, 2018
| export function getModuleSpecifier(compilerOptions: CompilerOptions, fromSourceFile: SourceFile, fromSourceFileName: string, toFileName: string, host: ModuleSpecifierResolutionHost, preferences: ModuleSpecifierPreferences = {}) { | ||
| const info = getInfo(compilerOptions, fromSourceFile, fromSourceFileName, host); | ||
| return getGlobalModuleSpecifier(toFileName, info, host, compilerOptions) || | ||
| // Note: importingSourceFile is just for usesJsExtensionOnImports |
There was a problem hiding this comment.
should that instead be a boolean flag?
There was a problem hiding this comment.
Let's do that in #25073 which is making this configurable.
mhegazy
approved these changes
Jun 21, 2018
| @@ -16,6 +16,9 @@ | |||
| //// "exclude": ["old"], | |||
| ////} | |||
|
|
|||
| // @Filename: /src/old/someFile.ts | |||
| //// | |||
There was a problem hiding this comment.
With this change it seems we need to have oldFile present on the disk? What about the tests when getEditsForRename when oldFile isnt present on the disk?
There was a problem hiding this comment.
For getEditsForFileRename to work, either oldFile xor newFile should be present. The tests start with oldFile present, verify the output of getEditsForFileRename, then rename the file, and verify the output of getEditsForFileRename again.
ghost
mentioned this pull request
sheetalkamat
approved these changes
Jun 25, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25059 and #25029
Updates the fourslash tests to run once before the rename, perform the rename, then run again. The bug in #25059 only reproduced if
getEditsForFileRenamewas called after the rename, which we weren't testing before.