-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when compiling a .js file #34861
Improve error message when compiling a .js file #34861
Conversation
Hi @lukahartwig - I really like this idea, I'm open to getting this in 👍 . Is it possible that for the last part of the sentence, you first check whether we are looking at a JavaScript or JSON file first? (It might need two error messages then) |
Good point, I try to make it work. |
Okay, so I added two error messages for JS and JSON files. For other extensions, it will fall back to the old message. I might need some help with the wording since I'm not a native speaker. I also wasn't able to reproduce the JSON file case with the baseline tests because apparently |
This is great @lukahartwig - the messages read good to me, let's get this in. I think it makes sense to remove the JSON error message then I'll merge! Thanks! |
Cool, I removed the JSON error message. Thanks for your help :) |
Thanks for contributing! |
Fixes #33585
I noticed this grammar error and saw that there already was an issue for it so I implemented the suggested changes.