Re-order reduce overloads #37702
Closed
Re-order reduce overloads #37702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okmttdhr
force-pushed
the
re-order-reduce-overloads
branch
from
2f252dd to
c38e5c7
Compare
okmttdhr
force-pushed
the
re-order-reduce-overloads
branch
from
c38e5c7 to
a9c4b65
Compare
|
Has the version 4.x been fixed? |
|
Unfortunately, too much time has passed since we accepted #7014, and any single change to Array methods is likely to be a breaking change whose cost outweighs its benefits. We should only consider fixing it with all the other Array methods in #36554. This PR should be closed since it's likely that the full Array method overhaul will look somewhat different. @okmttdhr does that sound OK to you? |
|
No problem, and I agree with that we should consider fixing it with all the other Array methods. I’m closing this PR |
|
The TypeScript team hasn't accepted the linked issue #7014. If you can get it accepted, this PR will have a better chance of being reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7014