Use homomorphic templated type for Omit #42524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
|
Seems like #34793 was already fixed, but this loses the ability for us to reuse type aliases. |
weswigham
commented
Jan 27, 2021
src/compiler/checker.ts
Outdated
| @@ -17925,7 +17925,7 @@ namespace ts { | |||
| } | |||
| } | |||
| } | |||
| else if (isGenericMappedType(target) && !target.declaration.nameType) { | |||
| else if (isGenericMappedType(target) && (!target.declaration.nameType || relation === comparableRelation)) { | |||
There was a problem hiding this comment.
Without this change and the bit below, you couldn't cast between an Omit of something and that something. That mapped types with nameType fields currently have no generic relations is a place we should probably improve upon anyway, however this is the minimal change required to get that comparable relation to work as expected.
|
Seems like this should close #31104, as it addresses the suggestion I made in #31104 (comment) |
|
Yeah, the issue ref is in the OP now. |
|
@typescript-bot perf test this |
|
Heya @weswigham, I've started to run the perf test suite on this PR at 743f49a. You can monitor the build here. Update: The results are in! |
|
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 743f49a. You can monitor the build here. |
|
Heya @weswigham, I've started to run the extended test suite on this PR at 743f49a. You can monitor the build here. |
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 743f49a. You can monitor the build here. |
|
@weswigham Here they are:Comparison Report - master..42524
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
@DanielRosenwasser when was #34793 "already fixed"? I still see it same as I always did :( |
|
It might not have - have you checked the nightlies with My assumption was it would've been fixed with #42284 where we'll preserve the origin types to remember that something was written as |
|
@DanielRosenwasser ah ok, no I haven't checked any nightlies, I badly assumed you meant in a public release. I'll check and report back. |
ExE-Boss
reviewed
Jan 31, 2021
|
Unfortunately, we never finished reviewing this PR. It is pretty old now, so I'm going to close it to reduce the number of open PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitas written today is non-homomorphic, so the original keys are unrecoverable when an index type subtype reduces with a key type. however, with #41976 in place, we can swapOmitover to use a template and be homomorphic, and fix two longstanding issues with one PR.Fixes #36981
Fixes #34793
Fixes #31104