Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(42639): "in" operator not narrowing the type if used with a const #44893

Merged
merged 1 commit into from
Jul 21, 2021
Merged

feat(42639): "in" operator not narrowing the type if used with a const #44893

merged 1 commit into from
Jul 21, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #42639

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 4, 2021
@gabritto gabritto self-assigned this Jul 21, 2021
@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Backlog Bug PRs that fix a backlog bug labels Jul 21, 2021
gabritto
gabritto reviewed Jul 21, 2021
View reviewed changes
Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a minor question, but otherwise looks good to me, thanks for contributing.

src/compiler/binder.ts Outdated Show resolved Hide resolved
@a-tarasyuk a-tarasyuk requested a review from gabritto July 21, 2021 15:27
gabritto
gabritto approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, everything seems good now

@gabritto gabritto merged commit e064817 into microsoft:main Jul 21, 2021
@andrewbranch
Copy link
Member

@typescript-bot perf test this

(not sure if it works on merged PRs?)

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 21, 2021 •
edited
Loading

Heya @andrewbranch, I've started to run the perf test suite on this PR at 278f172. You can monitor the build here.

@andrewbranch
Copy link
Member

(It doesn’t)

@gabritto gabritto mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabritto gabritto gabritto approved these changes

Assignees

@gabritto gabritto

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"in" operator not narrowing the type if used with a const
4 participants
@a-tarasyuk @andrewbranch @typescript-bot @gabritto