Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match TypedArray multiple-arguments constructor with MDN specifications #45039

Closed
wants to merge 1 commit into from

Conversation

Git-Lior
Copy link

@Git-Lior Git-Lior commented Jul 15, 2021

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/Uint8Array

The multiple-arguments constructor (buffer, byteOffset, length) accepts only an ArrayBuffer object as the first argument.
this can also be seen in the ECMAScript specifications at 6.b.iii.

this PR matches the specification with the d.ts, without effecting the other constructor signatures.

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 15, 2021
@Git-Lior Git-Lior closed this Jul 15, 2021
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@MartinJohns
Copy link
Contributor

@Git-Lior Why did you close the PR? This would fix #44191, wouldn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants