Clean up FAR aggregation #48619
Merged
Clean up FAR aggregation #48619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
From #48211 Benefits:
Costs:
Rough explanation of the new isDefinition:
|
|
@sheetalkamat I know @andrewbranch prefers the reduced complexity of this simplification, but I find its correctness less intuitively obvious. What are your thoughts on reverting that simplification commit? |
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
May 5, 2022
Getting an empty result doesn't seem expected, but a deeper fix doesn't make sense until microsoft#48619 is merged. Fixes microsoft#48963
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
May 5, 2022
Getting an empty result doesn't seem expected, but a deeper fix doesn't make sense until microsoft#48619 is merged. Fixes microsoft#48963
DanielRosenwasser
pushed a commit
that referenced
this pull request
May 5, 2022
This change had two goals: 1. Make the code easier to understand, primarily by simplifying the callback structure and minimizing side-effects 2. Improve performance by reducing repeated work, both FAR searches of individual projects and default tsconfig searches This implementation attempts to preserve the merging order found in the original code (someone less relevant in the present state of using syntactic isDefinition).
...in preparation for implementing isDefinition explicitly. Also restore convention of referring to `DocumentPosition`s as "locations".
...to allow use of the checker when computing isDefinition across projects.
|
Ping @sheetalkamat @andrewbranch now that we're in 4.8, this is ready for review. |
andrewbranch
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have library functions for searching within a project for symbols, references, rename locations, etc. All of that code is exactly as before - this change is about the layer that sits on top of that and aggregates the results across multiple projects. In the course of some performance investigations, I discovered that user-FAR was invoking per-project-FAR more times than I expected and that the code wasn't readable enough for me to confidently determine why or how to prevent it. This change attempts to address both issues.