JavaScript powered by TypeScript #5044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rly setting parents.
# Conflicts: # src/compiler/binder.ts
|
@ahejlsberg AMD support is removed; logic moved into the binder as we discussed. Let me know what you think. |
| * Returns the first invocation of an identifier 'require' with one argument, | ||
| * or undefined if that none exist. | ||
| */ | ||
| function findCommonJSRequireCalls(node: Node): Node { |
There was a problem hiding this comment.
This effectively does a full AST walk, which is expensive. We should just collect this information in the binder.
Fix up unit tests and remove AMD from lib files # Conflicts: # src/compiler/program.ts
| @@ -1775,6 +1779,7 @@ namespace ts { | |||
| importOnRightSide?: Symbol; // for import declarations - import that appear on the right side | |||
| jsxFlags?: JsxFlags; // flags for knowning what kind of element/attributes we're dealing with | |||
| resolvedJsxType?: Type; // resolved element attributes type of a JSX openinglike element | |||
| resolvedContextualType?: Type; // Cached contextual type of expression node | |||
| node.flags = node.flags | NodeFlags.InferredClass; | ||
| } | ||
| else { | ||
| let hasDeclaredProperties = forEachChild(node, child => child.kind === SyntaxKind.PropertyDeclaration); |
There was a problem hiding this comment.
Why are we doing this? We're in a TypeScript file here.
|
We should close this one. @RyanCavanaugh picked this up in a different PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a accumulation of several other PRs (support for JSDocs, supports for recognizing JavaScript modules etc...)