-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(50161): Instantiation expressions trigger incorrect error messages #52373
Conversation
@typescript-bot test this |
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at ebd498f. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at ebd498f. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the extended test suite on this PR at ebd498f. You can monitor the build here. |
Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at ebd498f. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the perf test suite on this PR at ebd498f. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at ebd498f. You can monitor the build here. |
Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at ebd498f. You can monitor the build here. Update: The results are in! |
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
@jakebailey Here they are:
CompilerComparison Report - main..52373
System
Hosts
Scenarios
TSServerComparison Report - main..52373
System
Hosts
Scenarios
StartupComparison Report - main..52373
System
Hosts
Scenarios
Developer Information: |
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
1 similar comment
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
Heyo. I'm currently running into this issue on 4.9.5. Any chance it can get ported and released as a patch to 4.9 (or was it and I'm somehow missing it)? Thanks. |
I don't think we're going to patch 4.9 anymore, but this will be in 5.0 which is out pretty soon (a few weeks). |
isHeritageClauseElementIdentifier
returnedmeaning
as only a Type and not a Value. Now it checks ifisPartOfTypeNode(name)
is true, then returnsmeaning
as a Type, else a Value.Fixes #50161