Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(50161): Instantiation expressions trigger incorrect error messages #52373

Merged
merged 9 commits into from
Jan 31, 2023

Conversation

navya9singh
Copy link
Member

isHeritageClauseElementIdentifier returned meaning as only a Type and not a Value. Now it checks if isPartOfTypeNode(name) is true, then returns meaning as a Type, else a Value.

Fixes #50161

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 23, 2023
src/compiler/checker.ts Outdated Show resolved Hide resolved
@andrewbranch andrewbranch self-requested a review January 23, 2023 17:56
src/compiler/checker.ts Outdated Show resolved Hide resolved
src/testRunner/tests.ts Show resolved Hide resolved
@jakebailey
Copy link
Member

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 30, 2023

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at ebd498f. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 30, 2023

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at ebd498f. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 30, 2023

Heya @jakebailey, I've started to run the extended test suite on this PR at ebd498f. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 30, 2023

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at ebd498f. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 30, 2023

Heya @jakebailey, I've started to run the perf test suite on this PR at ebd498f. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 30, 2023

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at ebd498f. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 30, 2023

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at ebd498f. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52373/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52373/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52373
Metric main 52373 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 359,850k (± 0.01%) 359,834k (± 0.01%) -17k (- 0.00%) 359,762k 359,883k
Parse Time 3.97s (± 0.78%) 3.98s (± 0.75%) +0.01s (+ 0.34%) 3.94s 4.02s
Bind Time 1.17s (± 0.71%) 1.18s (± 0.64%) +0.00s (+ 0.28%) 1.17s 1.19s
Check Time 8.65s (± 0.29%) 8.69s (± 0.49%) +0.04s (+ 0.44%) 8.61s 8.73s
Emit Time 7.60s (± 0.47%) 7.65s (± 0.74%) +0.04s (+ 0.55%) 7.57s 7.71s
Total Time 21.40s (± 0.25%) 21.49s (± 0.45%) +0.09s (+ 0.44%) 21.38s 21.61s
Compiler-Unions - node (v18.10.0, x64)
Memory used 196,315k (± 1.48%) 193,514k (± 1.17%) -2,801k (- 1.43%) 192,509k 198,157k
Parse Time 1.63s (± 1.75%) 1.66s (± 0.70%) +0.03s (+ 2.05%) 1.65s 1.68s
Bind Time 0.80s (± 0.65%) 0.80s (± 0.51%) +0.00s (+ 0.21%) 0.79s 0.80s
Check Time 9.63s (± 0.53%) 9.65s (± 0.68%) +0.03s (+ 0.28%) 9.60s 9.76s
Emit Time 2.83s (± 0.52%) 2.80s (± 0.54%) -0.02s (- 0.82%) 2.78s 2.82s
Total Time 14.88s (± 0.49%) 14.92s (± 0.46%) +0.04s (+ 0.25%) 14.87s 15.05s
Monaco - node (v18.10.0, x64)
Memory used 343,971k (± 0.01%) 343,989k (± 0.01%) +18k (+ 0.01%) 343,913k 344,046k
Parse Time 2.95s (± 0.76%) 2.96s (± 0.78%) +0.01s (+ 0.34%) 2.93s 3.00s
Bind Time 1.04s (± 1.00%) 1.04s (± 1.00%) 0.00s ( 0.00%) 1.02s 1.05s
Check Time 7.03s (± 0.51%) 7.05s (± 0.58%) +0.02s (+ 0.33%) 6.99s 7.10s
Emit Time 4.29s (± 0.48%) 4.33s (± 1.05%) +0.04s (+ 0.85%) 4.28s 4.39s
Total Time 15.31s (± 0.34%) 15.38s (± 0.41%) +0.06s (+ 0.41%) 15.27s 15.43s
TFS - node (v18.10.0, x64)
Memory used 300,374k (± 0.01%) 300,385k (± 0.01%) +12k (+ 0.00%) 300,352k 300,419k
Parse Time 2.24s (± 0.80%) 2.27s (± 1.09%) +0.03s (+ 1.26%) 2.24s 2.31s
Bind Time 1.17s (± 0.47%) 1.18s (± 1.98%) +0.01s (+ 0.85%) 1.17s 1.23s
Check Time 6.52s (± 0.42%) 6.54s (± 0.30%) +0.02s (+ 0.28%) 6.51s 6.57s
Emit Time 3.92s (± 0.73%) 3.94s (± 0.78%) +0.02s (+ 0.51%) 3.90s 3.99s
Total Time 13.85s (± 0.36%) 13.93s (± 0.41%) +0.08s (+ 0.55%) 13.88s 14.02s
material-ui - node (v18.10.0, x64)
Memory used 476,737k (± 0.01%) 476,730k (± 0.01%) -7k (- 0.00%) 476,680k 476,858k
Parse Time 3.55s (± 0.90%) 3.56s (± 1.52%) +0.00s (+ 0.00%) 3.45s 3.60s
Bind Time 0.96s (± 0.57%) 1.00s (± 7.11%) +0.03s (+ 3.28%) 0.95s 1.14s
Check Time 17.05s (± 0.31%) 17.08s (± 0.53%) +0.02s (+ 0.13%) 16.91s 17.17s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.57s (± 0.25%) 21.63s (± 0.38%) +0.06s (+ 0.26%) 21.49s 21.71s
xstate - node (v18.10.0, x64)
Memory used 548,597k (± 0.02%) 548,710k (± 0.02%) +113k (+ 0.02%) 548,478k 548,822k
Parse Time 4.58s (± 0.34%) 4.58s (± 0.45%) -0.00s (- 0.11%) 4.55s 4.61s
Bind Time 1.71s (± 0.83%) 1.71s (± 1.25%) +0.00s (+ 0.10%) 1.68s 1.74s
Check Time 2.73s (± 0.76%) 2.73s (± 1.32%) +0.01s (+ 0.31%) 2.69s 2.77s
Emit Time 0.08s (± 6.44%) 0.08s (± 0.00%) 🟩-0.00s (- 5.88%) 0.08s 0.08s
Total Time 9.11s (± 0.23%) 9.11s (± 0.64%) +0.00s (+ 0.04%) 9.00s 9.16s
Angular - node (v16.17.1, x64)
Memory used 359,212k (± 0.01%) 359,224k (± 0.01%) +12k (+ 0.00%) 359,201k 359,255k
Parse Time 4.19s (± 0.52%) 4.20s (± 0.33%) +0.01s (+ 0.16%) 4.17s 4.21s
Bind Time 1.23s (± 0.33%) 1.22s (± 0.45%) -0.00s (- 0.27%) 1.22s 1.23s
Check Time 9.40s (± 0.17%) 9.39s (± 0.09%) -0.00s (- 0.00%) 9.39s 9.41s
Emit Time 8.06s (± 0.32%) 8.07s (± 0.43%) +0.02s (+ 0.19%) 8.02s 8.10s
Total Time 22.87s (± 0.14%) 22.89s (± 0.14%) +0.02s (+ 0.07%) 22.85s 22.93s
Compiler-Unions - node (v16.17.1, x64)
Memory used 194,824k (± 0.69%) 194,870k (± 0.71%) +46k (+ 0.02%) 194,247k 197,687k
Parse Time 1.81s (± 0.65%) 1.82s (± 0.58%) +0.01s (+ 0.37%) 1.80s 1.83s
Bind Time 0.84s (± 0.99%) 0.84s (± 1.22%) -0.00s (- 0.20%) 0.83s 0.86s
Check Time 10.38s (± 0.13%) 10.38s (± 0.78%) -0.00s (- 0.02%) 10.31s 10.50s
Emit Time 3.07s (± 0.91%) 3.07s (± 1.08%) -0.00s (- 0.05%) 3.02s 3.12s
Total Time 16.11s (± 0.28%) 16.11s (± 0.61%) 0.00s ( 0.00%) 16.01s 16.23s
Monaco - node (v16.17.1, x64)
Memory used 343,234k (± 0.01%) 343,240k (± 0.01%) +6k (+ 0.00%) 343,225k 343,282k
Parse Time 3.15s (± 1.00%) 3.20s (± 1.00%) +0.04s (+ 1.37%) 3.17s 3.26s
Bind Time 1.12s (± 0.75%) 1.11s (± 0.37%) -0.00s (- 0.30%) 1.11s 1.12s
Check Time 7.71s (± 0.51%) 7.73s (± 0.46%) +0.02s (+ 0.22%) 7.69s 7.78s
Emit Time 4.53s (± 0.40%) 4.55s (± 1.38%) +0.02s (+ 0.44%) 4.49s 4.67s
Total Time 16.51s (± 0.43%) 16.59s (± 0.55%) +0.08s (+ 0.47%) 16.51s 16.76s
TFS - node (v16.17.1, x64)
Memory used 299,757k (± 0.01%) 299,767k (± 0.01%) +10k (+ 0.00%) 299,750k 299,793k
Parse Time 2.49s (± 1.46%) 2.47s (± 1.01%) -0.02s (- 0.87%) 2.44s 2.50s
Bind Time 1.26s (± 0.65%) 1.25s (± 0.67%) -0.00s (- 0.13%) 1.24s 1.26s
Check Time 7.19s (± 0.34%) 7.19s (± 0.52%) +0.00s (+ 0.02%) 7.12s 7.22s
Emit Time 4.22s (± 0.71%) 4.21s (± 0.38%) -0.01s (- 0.16%) 4.20s 4.24s
Total Time 15.15s (± 0.22%) 15.12s (± 0.42%) -0.03s (- 0.22%) 15.04s 15.23s
material-ui - node (v16.17.1, x64)
Memory used 476,058k (± 0.01%) 476,041k (± 0.01%) -17k (- 0.00%) 475,993k 476,113k
Parse Time 3.71s (± 0.28%) 3.71s (± 0.28%) -0.00s (- 0.04%) 3.70s 3.72s
Bind Time 1.02s (± 0.00%) 1.02s (± 0.40%) +0.00s (+ 0.16%) 1.02s 1.03s
Check Time 18.09s (± 0.26%) 18.13s (± 0.70%) +0.04s (+ 0.24%) 18.00s 18.36s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.82s (± 0.23%) 22.87s (± 0.53%) +0.04s (+ 0.19%) 22.75s 23.09s
xstate - node (v16.17.1, x64)
Memory used 546,219k (± 0.00%) 546,256k (± 0.01%) +37k (+ 0.01%) 546,212k 546,347k
Parse Time 4.76s (± 0.31%) 4.77s (± 0.28%) +0.01s (+ 0.21%) 4.75s 4.78s
Bind Time 1.81s (± 3.80%) 1.82s (± 3.96%) +0.01s (+ 0.46%) 1.67s 1.85s
Check Time 3.00s (± 2.49%) 2.99s (± 2.58%) -0.00s (- 0.11%) 2.94s 3.15s
Emit Time 0.09s (± 5.53%) 0.10s (± 5.34%) +0.00s (+ 3.57%) 0.09s 0.10s
Total Time 9.66s (± 0.22%) 9.68s (± 0.23%) +0.02s (+ 0.16%) 9.64s 9.70s
Angular - node (v14.15.1, x64)
Memory used 352,848k (± 0.01%) 352,839k (± 0.01%) -9k (- 0.00%) 352,807k 352,872k
Parse Time 4.23s (± 0.46%) 4.25s (± 0.49%) +0.02s (+ 0.55%) 4.24s 4.29s
Bind Time 1.28s (± 0.59%) 1.28s (± 0.32%) 0.00s ( 0.00%) 1.28s 1.29s
Check Time 9.70s (± 0.40%) 9.74s (± 0.53%) +0.04s (+ 0.45%) 9.66s 9.79s
Emit Time 8.39s (± 0.84%) 8.41s (± 0.62%) +0.02s (+ 0.24%) 8.35s 8.48s
Total Time 23.60s (± 0.39%) 23.69s (± 0.46%) +0.09s (+ 0.37%) 23.54s 23.83s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,750k (± 0.75%) 189,647k (± 0.69%) -103k (- 0.05%) 189,097k 192,338k
Parse Time 1.84s (± 0.53%) 1.84s (± 0.22%) +0.00s (+ 0.00%) 1.84s 1.85s
Bind Time 0.86s (± 0.94%) 0.86s (± 0.48%) -0.01s (- 0.58%) 0.85s 0.86s
Check Time 10.40s (± 0.19%) 10.39s (± 0.71%) -0.00s (- 0.05%) 10.28s 10.46s
Emit Time 3.39s (± 5.68%) 3.48s (± 1.29%) +0.08s (+ 2.46%) 3.40s 3.53s
Total Time 16.49s (± 1.24%) 16.57s (± 0.53%) +0.08s (+ 0.50%) 16.46s 16.68s
Monaco - node (v14.15.1, x64)
Memory used 338,034k (± 0.01%) 338,033k (± 0.00%) -2k (- 0.00%) 338,010k 338,050k
Parse Time 3.24s (± 1.10%) 3.24s (± 0.87%) -0.01s (- 0.21%) 3.21s 3.28s
Bind Time 1.11s (± 0.37%) 1.11s (± 0.80%) -0.00s (- 0.15%) 1.10s 1.12s
Check Time 8.08s (± 0.43%) 8.06s (± 0.27%) -0.02s (- 0.21%) 8.04s 8.10s
Emit Time 4.76s (± 0.41%) 4.75s (± 0.67%) -0.01s (- 0.18%) 4.71s 4.79s
Total Time 17.19s (± 0.23%) 17.16s (± 0.26%) -0.03s (- 0.18%) 17.09s 17.22s
TFS - node (v14.15.1, x64)
Memory used 294,582k (± 0.01%) 294,569k (± 0.01%) -13k (- 0.00%) 294,546k 294,591k
Parse Time 2.75s (± 0.74%) 2.77s (± 1.11%) +0.02s (+ 0.67%) 2.72s 2.81s
Bind Time 1.11s (± 0.57%) 1.11s (± 0.46%) +0.00s (+ 0.30%) 1.11s 1.12s
Check Time 7.51s (± 0.66%) 7.50s (± 0.81%) -0.01s (- 0.09%) 7.45s 7.62s
Emit Time 4.61s (± 0.82%) 4.62s (± 0.90%) +0.00s (+ 0.00%) 4.58s 4.68s
Total Time 15.99s (± 0.46%) 16.00s (± 0.32%) +0.01s (+ 0.07%) 15.93s 16.06s
material-ui - node (v14.15.1, x64)
Memory used 471,548k (± 0.00%) 471,557k (± 0.00%) +9k (+ 0.00%) 471,526k 471,587k
Parse Time 3.92s (± 0.35%) 3.95s (± 0.65%) +0.03s (+ 0.85%) 3.91s 3.97s
Bind Time 1.05s (± 1.11%) 1.05s (± 0.49%) -0.00s (- 0.16%) 1.04s 1.05s
Check Time 19.02s (± 0.31%) 19.11s (± 0.73%) +0.09s (+ 0.50%) 18.97s 19.33s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 23.98s (± 0.26%) 24.11s (± 0.61%) +0.13s (+ 0.53%) 23.97s 24.34s
xstate - node (v14.15.1, x64)
Memory used 534,462k (± 0.01%) 534,461k (± 0.01%) -1k (- 0.00%) 534,425k 534,513k
Parse Time 5.16s (± 1.08%) 5.19s (± 1.21%) +0.03s (+ 0.61%) 5.09s 5.28s
Bind Time 1.72s (± 0.49%) 1.71s (± 0.24%) -0.01s (- 0.39%) 1.70s 1.71s
Check Time 3.09s (± 0.63%) 3.09s (± 0.26%) +0.01s (+ 0.16%) 3.08s 3.10s
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) 0.00s ( 0.00%) 0.10s 0.10s
Total Time 10.06s (± 0.61%) 10.09s (± 0.56%) +0.03s (+ 0.33%) 10.01s 10.18s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52373 6
Baseline main 6

TSServer

Comparison Report - main..52373
Metric main 52373 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,560ms (± 1.26%) 2,518ms (± 1.78%) -41ms (- 1.61%) 2,475ms 2,599ms
Req 2 - geterr 5,512ms (± 0.50%) 5,502ms (± 0.75%) -10ms (- 0.18%) 5,455ms 5,564ms
Req 3 - references 364ms (± 0.41%) 367ms (± 1.80%) +2ms (+ 0.64%) 360ms 378ms
Req 4 - navto 285ms (± 0.29%) 285ms (± 0.79%) 0ms ( 0.00%) 281ms 288ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 66ms (± 0.62%) 66ms (± 3.65%) +1ms (+ 0.76%) 64ms 71ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,738ms (± 1.29%) 2,720ms (± 0.71%) -19ms (- 0.68%) 2,701ms 2,752ms
Req 2 - geterr 4,051ms (± 0.42%) 4,064ms (± 0.51%) +14ms (+ 0.33%) 4,036ms 4,098ms
Req 3 - references 367ms (± 0.40%) 368ms (± 0.32%) +1ms (+ 0.18%) 366ms 369ms
Req 4 - navto 298ms (± 1.23%) 300ms (± 0.49%) +2ms (+ 0.67%) 298ms 302ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 78ms (± 7.51%) 82ms (± 1.84%) +4ms (+ 4.48%) 79ms 83ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,491ms (± 0.52%) 3,497ms (± 0.54%) +7ms (+ 0.19%) 3,471ms 3,519ms
Req 2 - geterr 1,414ms (± 1.06%) 1,412ms (± 1.03%) -2ms (- 0.15%) 1,390ms 1,434ms
Req 3 - references 104ms (± 1.69%) 105ms (± 1.64%) +2ms (+ 1.45%) 103ms 107ms
Req 4 - navto 357ms (± 1.88%) 357ms (± 1.14%) -1ms (- 0.14%) 352ms 364ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 472ms (± 1.06%) 466ms (± 1.33%) -6ms (- 1.20%) 459ms 477ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,779ms (± 0.95%) 2,795ms (± 0.48%) +16ms (+ 0.59%) 2,784ms 2,817ms
Req 2 - geterr 5,900ms (± 0.18%) 5,881ms (± 0.75%) -19ms (- 0.32%) 5,836ms 5,939ms
Req 3 - references 376ms (± 0.77%) 378ms (± 2.08%) +2ms (+ 0.62%) 370ms 388ms
Req 4 - navto 278ms (± 0.81%) 280ms (± 0.44%) +2ms (+ 0.72%) 278ms 281ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 73ms (± 4.46%) 74ms (± 3.85%) +1ms (+ 1.83%) 71ms 78ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,945ms (± 0.42%) 2,943ms (± 0.36%) -2ms (- 0.07%) 2,929ms 2,960ms
Req 2 - geterr 4,390ms (± 0.37%) 4,393ms (± 0.32%) +3ms (+ 0.06%) 4,382ms 4,413ms
Req 3 - references 380ms (± 0.87%) 380ms (± 0.45%) 0ms ( 0.00%) 378ms 382ms
Req 4 - navto 287ms (± 0.52%) 288ms (± 0.75%) +0ms (+ 0.12%) 285ms 291ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 72ms (± 1.14%) 72ms (± 0.77%) -0ms (- 0.23%) 71ms 72ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,633ms (± 0.26%) 3,635ms (± 0.59%) +2ms (+ 0.05%) 3,608ms 3,664ms
Req 2 - geterr 1,570ms (± 1.01%) 1,557ms (± 0.37%) -13ms (- 0.84%) 1,546ms 1,563ms
Req 3 - references 111ms (± 1.61%) 111ms (± 2.52%) +0ms (+ 0.30%) 108ms 116ms
Req 4 - navto 343ms (± 1.28%) 341ms (± 0.78%) -3ms (- 0.78%) 339ms 346ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 484ms (± 1.04%) 483ms (± 0.98%) -1ms (- 0.10%) 478ms 490ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,910ms (± 0.51%) 2,908ms (± 0.35%) -2ms (- 0.06%) 2,892ms 2,920ms
Req 2 - geterr 6,270ms (± 0.28%) 6,293ms (± 0.39%) +24ms (+ 0.38%) 6,259ms 6,333ms
Req 3 - references 388ms (± 0.30%) 389ms (± 0.57%) +1ms (+ 0.17%) 385ms 391ms
Req 4 - navto 284ms (± 1.14%) 284ms (± 0.99%) +1ms (+ 0.18%) 281ms 288ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 82ms (± 6.72%) 86ms (± 8.95%) +3ms (+ 3.85%) 73ms 93ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,088ms (± 0.90%) 3,090ms (± 0.92%) +2ms (+ 0.07%) 3,064ms 3,136ms
Req 2 - geterr 4,700ms (± 0.39%) 4,694ms (± 0.45%) -6ms (- 0.12%) 4,673ms 4,734ms
Req 3 - references 407ms (± 1.18%) 407ms (± 0.97%) +1ms (+ 0.12%) 402ms 413ms
Req 4 - navto 291ms (± 0.74%) 293ms (± 1.34%) +3ms (+ 0.92%) 288ms 298ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 81ms (± 1.01%) 84ms (± 4.59%) +4ms (+ 4.34%) 80ms 88ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,971ms (± 0.67%) 3,966ms (± 0.33%) -5ms (- 0.13%) 3,947ms 3,983ms
Req 2 - geterr 1,512ms (± 0.26%) 1,525ms (± 0.84%) +13ms (+ 0.86%) 1,508ms 1,538ms
Req 3 - references 134ms (± 2.60%) 134ms (± 3.02%) -1ms (- 0.50%) 129ms 140ms
Req 4 - navto 372ms (± 0.70%) 375ms (± 0.69%) +3ms (+ 0.85%) 372ms 379ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 505ms (± 1.78%) 507ms (± 1.92%) +2ms (+ 0.33%) 489ms 515ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52373 6
Baseline main 6

Startup

Comparison Report - main..52373
Metric main 52373 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 142.44ms (± 0.17%) 142.97ms (± 0.17%) +0.54ms (+ 0.38%) 142.06ms 145.00ms
tsserver-startup - node (v16.17.1, x64)
Execution time 226.96ms (± 0.18%) 230.08ms (± 0.47%) +3.12ms (+ 1.37%) 226.74ms 236.88ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 229.13ms (± 0.16%) 230.80ms (± 0.36%) +1.67ms (+ 0.73%) 228.43ms 237.82ms
typescript-startup - node (v16.17.1, x64)
Execution time 210.02ms (± 0.14%) 212.61ms (± 0.39%) +2.59ms (+ 1.23%) 209.51ms 218.96ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52373 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52373/merge:

Everything looks good!

1 similar comment
@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52373/merge:

Everything looks good!

@jimmynotjim
Copy link

Heyo. I'm currently running into this issue on 4.9.5. Any chance it can get ported and released as a patch to 4.9 (or was it and I'm somehow missing it)? Thanks.

@jakebailey
Copy link
Member

I don't think we're going to patch 4.9 anymore, but this will be in 5.0 which is out pretty soon (a few weeks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instantiation expressions inconsistently trigger incorrect error messages in editor contexts
5 participants