Cache getConstraintOfDistributiveConditionalType #53358

jakebailey · 2023-03-19T19:39:34Z

In the perf graphs of #53346, a lot of the time is spent in getConstraintOfDistributiveConditionalType. We can cache it like getDefaultConstraintOfConditionalType. This function can return undefined, so we have to use a different value than undefined to indicate this case (as undefined is "not yet calculated").

On top of main, this nets:

Benchmark 1: main
  Time (mean ± σ):     19.155 s ±  0.163 s    [User: 16.576 s, System: 2.573 s]
  Range (min … max):   18.905 s … 19.563 s    20 runs
 
Benchmark 2: new
  Time (mean ± σ):     16.842 s ±  0.352 s    [User: 14.326 s, System: 2.511 s]
  Range (min … max):   16.315 s … 18.002 s    20 runs
 
Summary
  'new' ran
    1.14 ± 0.03 times faster than 'main'

This compounds with #53346; both together nets:

Benchmark 1: main
  Time (mean ± σ):     19.118 s ±  0.241 s    [User: 16.597 s, System: 2.513 s]
  Range (min … max):   18.626 s … 19.485 s    20 runs
 
Benchmark 2: new
  Time (mean ± σ):     11.757 s ±  0.296 s    [User: 10.019 s, System: 1.732 s]
  Range (min … max):   11.218 s … 12.257 s    20 runs
 
Summary
  'new' ran
    1.63 ± 0.05 times faster than 'main'

…Type

jakebailey · 2023-03-19T19:39:52Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-03-19T19:39:55Z

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 5301906. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T19:39:55Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 5301906. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T19:39:55Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 5301906. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T19:39:55Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 5301906. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T19:39:55Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 5301906. You can monitor the build here.

typescript-bot · 2023-03-19T19:54:03Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53358/merge:

Everything looks good!

typescript-bot · 2023-03-19T19:55:04Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53358

_Metric	_main	₅₃₃₅₈	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,043k (± 0.01%)}	_{361,063k (± 0.01%)}	_~	_361,022k	_361,092k	_{p=0.230 n=6}
_{Parse Time}	_{3.53s (± 0.87%)}	_{3.52s (± 0.61%)}	_~	_3.49s	_3.55s	_{p=0.808 n=6}
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.18s (± 0.44%)}	_~	_1.18s	_1.19s	_{p=0.640 n=6}
_{Check Time}	_{9.48s (± 0.49%)}	_{9.44s (± 0.13%)}	_~	_9.42s	_9.45s	_{p=0.124 n=6}
_{Emit Time}	_{7.93s (± 0.82%)}	_{7.91s (± 0.59%)}	_~	_7.86s	_7.99s	_{p=0.747 n=6}
_{Total Time}	_{22.13s (± 0.53%)}	_{22.05s (± 0.20%)}	_~	_21.99s	_22.10s	_{p=0.470 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,558k (± 0.02%)}	_{192,546k (± 0.04%)}	_~	_192,451k	_192,641k	_{p=0.689 n=6}
_{Parse Time}	_{1.59s (± 0.86%)}	_{1.57s (± 1.42%)}	_~	_1.54s	_1.59s	_{p=0.067 n=6}
_{Bind Time}	_{0.82s (± 0.63%)}	_{0.82s (± 0.00%)}	_~	_0.82s	_0.82s	_{p=0.174 n=6}
_{Check Time}	_{10.15s (± 0.87%)}	_{10.07s (± 0.74%)}	_~	_9.98s	_10.16s	_{p=0.286 n=6}
_{Emit Time}	_{3.00s (± 0.25%)}	_{2.99s (± 0.95%)}	_~	_2.96s	_3.04s	_{p=0.164 n=6}
_{Total Time}	_{15.56s (± 0.51%)}	_{15.46s (± 0.68%)}	_~	_15.36s	_15.61s	_{p=0.108 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,570k (± 0.01%)}	_{345,572k (± 0.00%)}	_~	_345,549k	_345,588k	_{p=0.689 n=6}
_{Parse Time}	_{2.73s (± 0.60%)}	_{2.72s (± 0.60%)}	_~	_2.70s	_2.74s	_{p=0.088 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 1.00%)}	_~	_1.08s	_1.11s	_{p=0.324 n=6}
_{Check Time}	_{7.70s (± 0.41%)}	_{7.69s (± 0.29%)}	_~	_7.67s	_7.73s	_{p=0.421 n=6}
_{Emit Time}	_{4.46s (± 0.49%)}	_{4.44s (± 0.88%)}	_~	_4.39s	_4.49s	_{p=0.332 n=6}
_{Total Time}	_{15.98s (± 0.35%)}	_{15.94s (± 0.44%)}	_~	_15.85s	_16.02s	_{p=0.298 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,817k (± 0.01%)}	_{299,807k (± 0.01%)}	_~	_299,760k	_299,856k	_{p=0.689 n=6}
_{Parse Time}	_{2.17s (± 0.54%)}	_{2.18s (± 0.80%)}	_~	_2.16s	_2.21s	_{p=0.251 n=6}
_{Bind Time}	_{1.24s (± 0.97%)}	_{1.24s (± 0.85%)}	_~	_1.22s	_1.25s	_{p=0.282 n=6}
_{Check Time}	_{7.17s (± 0.54%)}	_{7.16s (± 0.49%)}	_~	_7.10s	_7.20s	_{p=0.629 n=6}
_{Emit Time}	_{4.34s (± 0.63%)}	_{4.36s (± 0.61%)}	_~	_4.32s	_4.39s	_{p=0.624 n=6}
_{Total Time}	_{14.93s (± 0.24%)}	_{14.94s (± 0.38%)}	_~	_14.86s	_15.00s	_{p=0.748 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,408k (± 0.01%)}	_{476,407k (± 0.00%)}	_~	_476,369k	_476,427k	_{p=0.471 n=6}
_{Parse Time}	_{3.21s (± 0.61%)}	_{3.22s (± 0.33%)}	_~	_3.20s	_3.23s	_{p=1.000 n=6}
_{Bind Time}	_{0.95s (± 0.43%)}	_{0.95s (± 0.54%)}	_~	_0.95s	_0.96s	_{p=0.595 n=6}
_{Check Time}	_{17.91s (± 0.86%)}	_{17.90s (± 0.69%)}	_~	_17.76s	_18.12s	_{p=0.748 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.08s (± 0.62%)}	_{22.07s (± 0.57%)}	_~	_21.93s	_22.29s	_{p=0.688 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,624k (± 0.02%)}	_{550,652k (± 0.02%)}	_~	_550,529k	_550,780k	_{p=0.689 n=6}
_{Parse Time}	_{3.95s (± 0.16%)}	_{3.94s (± 0.35%)}	_~	_3.92s	_3.96s	_{p=0.510 n=6}
_{Bind Time}	_{1.80s (± 0.29%)}	_{1.79s (± 0.29%)}	_~	_1.79s	_1.80s	_{p=0.311 n=6}
_{Check Time}	_{3.04s (± 0.34%)}	_{3.05s (± 0.93%)}	_~	_3.01s	_3.08s	_{p=0.332 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.88s (± 0.17%)}	_{8.88s (± 0.29%)}	_~	_8.86s	_8.92s	_{p=1.000 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₅₈	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-03-19T21:31:40Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53358/merge:

Everything looks good!

typescript-bot · 2023-03-19T21:39:25Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

weswigham · 2023-03-27T20:01:25Z

src/compiler/types.ts

@@ -6630,6 +6630,8 @@ export interface ConditionalType extends InstantiableType {
    /** @internal */
    resolvedDefaultConstraint?: Type;
    /** @internal */
+    resolvedDefaultConstraintOfDistributed?: Type | false;


Suggested change

resolvedDefaultConstraintOfDistributed?: Type | false;

resolvedDefaultConstraintOfDistributive?: Type | false;

it'd be weird to not match the function name, y'know. Plus, a distributive conditional we're getting the distributive constraint of can't have been distributed yet, since, if it was, we wouldn't have a distributive conditional anymore.

Hm, then maybe this should really just be resolvedConstraintOfDistributive to match the function? I think I brainfarted when copying the declaration above to rename it and just kept the word "default" without thinking about it.

I changed it to the straight substring of the function name, which isn't exactly what you said but I think is actually correct.

…lType

Don't recalculate undefined in getConstraintOfDistributiveConditional…

Verified

This commit was signed with the committer’s verified signature. The key has expired.

mjcarroll Michael Carroll

GPG key ID: F20ABF421A696F36
Expired

Verified
Learn about vigilant mode

5301906

…Type

typescript-bot assigned jakebailey Mar 19, 2023

typescript-bot added Author: Team For Uncommitted Bug labels Mar 19, 2023

sandersn requested review from rbuckton and weswigham March 27, 2023 18:32

weswigham reviewed Mar 27, 2023

View reviewed changes

jakebailey added 2 commits March 27, 2023 13:06

Merge branch 'main' into faster-getConstraintOfDistributiveConditiona…

Verified

This commit was signed with the committer’s verified signature. The key has expired.

mjcarroll Michael Carroll

GPG key ID: F20ABF421A696F36
Expired

Verified
Learn about vigilant mode

516b731

…lType

Rename to resolvedConstraintOfDistributive

Verified

This commit was signed with the committer’s verified signature. The key has expired.

mjcarroll Michael Carroll

GPG key ID: F20ABF421A696F36
Expired

Verified
Learn about vigilant mode

c92c51d

weswigham approved these changes Mar 27, 2023

View reviewed changes

jakebailey merged commit 3efcfcb into microsoft:main Mar 27, 2023

jakebailey deleted the faster-getConstraintOfDistributiveConditionalType branch March 27, 2023 21:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cache getConstraintOfDistributiveConditionalType #53358

Cache getConstraintOfDistributiveConditionalType #53358

jakebailey commented Mar 19, 2023

jakebailey commented Mar 19, 2023

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023

typescript-bot commented Mar 19, 2023

typescript-bot commented Mar 19, 2023

typescript-bot commented Mar 19, 2023

weswigham Mar 27, 2023

jakebailey Mar 27, 2023

jakebailey Mar 27, 2023

	resolvedDefaultConstraintOfDistributed?: Type \| false;
	resolvedDefaultConstraintOfDistributive?: Type \| false;

Cache getConstraintOfDistributiveConditionalType #53358

Cache getConstraintOfDistributiveConditionalType #53358

Conversation

jakebailey commented Mar 19, 2023

jakebailey commented Mar 19, 2023

typescript-bot commented Mar 19, 2023 • edited Loading

typescript-bot commented Mar 19, 2023 • edited Loading

typescript-bot commented Mar 19, 2023 • edited Loading

typescript-bot commented Mar 19, 2023 • edited Loading

typescript-bot commented Mar 19, 2023 • edited Loading

typescript-bot commented Mar 19, 2023

typescript-bot commented Mar 19, 2023

typescript-bot commented Mar 19, 2023

typescript-bot commented Mar 19, 2023

weswigham Mar 27, 2023

Choose a reason for hiding this comment

jakebailey Mar 27, 2023

Choose a reason for hiding this comment

jakebailey Mar 27, 2023

Choose a reason for hiding this comment

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading