Source files not affected by all module resolution options #55790

sheetalkamat · 2023-09-19T21:51:09Z

Stops taking dependency on all module resolution options when sharing sourceFiles and instead moves resolvedModules and resolvedTypeReferenceDirectiveNames from sourceFile to Program so it is safe by program to copy the resolutions across.

This came up as part of testing with #54785 where axion and some more (which i dont recollect) didnt pass incremental resolution check. This is shown in ddaf1c7 specifically (ddaf1c7#diff-215d7c39ab1082f80d4c3a4f1c8bd9dd1c9ccb1c6450192bbaf409b8e5376579R140) where the resolved module on sourceFile changes and results in issues program referencing other resolution.
The issue here lies in fact that "as type" resolution takes into account typeRoots and if config had it its good and used as a key for affecting resolution but if user didnt specify it depends on "config file location" if present otherwise "currentDirectory" . This is issue because you could include either by types or default types (matching in both projects) a type thats in parent directories node_modules/@types but then that type could include types directive of say node which in both projects will be resolved say from config location which is different and if those directories have their own node_modules/@types/node then the location which is picked will depend on which project is picked first
Investigated few options for this

adding default type roots as key but that mean resolutions cannot be shared between two projects with config file in different directories which is very common.
On top of above option adding only present node_modules/@types in the key but that means on each npm install we would need to update module resolutions from scratch as its change in "key" and parse "sourceFiles" so that doesnt seem practical
The current change where decoupling sourceFiles and module resolution storage, This doesnt fix module resolution cache sharing across projects (which is only in tsbuild for now which doesnt share the caches between watch events and in future we will share in tsserver but that one will watch failed lookup locations so we could somehow use that so probably can be handled in some way without having to invalidate everything)

sheetalkamat · 2023-09-20T00:13:00Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot test tsserver top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot perf test this

typescript-bot · 2023-09-20T00:13:06Z

Heya @sheetalkamat, I've started to run the diff-based user code test suite on this PR at 6a43bc1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T00:13:06Z

Heya @sheetalkamat, I've started to run the diff-based top-repos suite on this PR at 6a43bc1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T00:13:06Z

Heya @sheetalkamat, I've started to run the diff-based top-repos suite (tsserver) on this PR at 6a43bc1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T00:13:06Z

Heya @sheetalkamat, I've started to run the regular perf test suite on this PR at 6a43bc1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T00:13:06Z

Heya @sheetalkamat, I've started to run the diff-based user code test suite (tsserver) on this PR at 6a43bc1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T00:33:19Z

@sheetalkamat Here are the results of running the user test suite comparing main and refs/pull/55790/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-09-20T00:36:08Z

@sheetalkamat
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{294,913k (± 0.01%)}	_{294,919k (± 0.01%)}	_~	_294,872k	_294,950k	_{p=0.936 n=6}
_{Parse Time}	_{2.63s (± 0.21%)}	_{2.63s (± 0.48%)}	_~	_2.61s	_2.64s	_{p=0.663 n=6}
_{Bind Time}	_{0.84s (± 1.22%)}	_{0.84s (± 1.17%)}	_~	_0.83s	_0.85s	_{p=0.784 n=6}
_{Check Time}	_{8.00s (± 0.29%)}	_{8.00s (± 0.38%)}	_~	_7.96s	_8.05s	_{p=1.000 n=6}
_{Emit Time}	_{7.02s (± 0.19%)}	_{7.01s (± 0.24%)}	_~	_6.99s	_7.03s	_{p=0.505 n=6}
_{Total Time}	_{18.49s (± 0.12%)}	_{18.48s (± 0.13%)}	_~	_18.45s	_18.51s	_{p=0.511 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,525k (± 1.54%)}	_{193,575k (± 1.67%)}	_~	_190,610k	_196,653k	_{p=0.298 n=6}
_{Parse Time}	_{1.36s (± 0.72%)}	_{1.36s (± 0.55%)}	_~	_1.35s	_1.37s	_{p=1.000 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.07s (± 0.52%)}	_{9.07s (± 0.31%)}	_~	_9.04s	_9.11s	_{p=0.872 n=6}
_{Emit Time}	_{2.60s (± 0.52%)}	_{2.61s (± 1.10%)}	_~	_2.58s	_2.66s	_{p=0.624 n=6}
_{Total Time}	_{13.77s (± 0.41%)}	_{13.78s (± 0.40%)}	_~	_13.71s	_13.84s	_{p=0.746 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,182k (± 0.00%)}	_{347,201k (± 0.00%)}	_{+20k (+ 0.01%)}	_347,189k	_347,215k	_{p=0.013 n=6}
_{Parse Time}	_{2.47s (± 0.30%)}	_{2.47s (± 0.36%)}	_~	_2.46s	_2.48s	_{p=0.798 n=6}
_{Bind Time}	_{0.94s (± 0.55%)}	_{0.94s (± 0.43%)}	_~	_0.94s	_0.95s	_{p=0.114 n=6}
_{Check Time}	_{6.86s (± 0.54%)}	_{6.88s (± 0.47%)}	_~	_6.83s	_6.92s	_{p=0.466 n=6}
_{Emit Time}	_{4.03s (± 0.56%)}	_{4.04s (± 0.48%)}	_~	_4.01s	_4.06s	_{p=0.569 n=6}
_{Total Time}	_{14.30s (± 0.34%)}	_{14.32s (± 0.26%)}	_~	_14.27s	_14.38s	_{p=0.416 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,474k (± 0.01%)}	_{302,476k (± 0.01%)}	_~	_302,457k	_302,496k	_{p=0.575 n=6}
_{Parse Time}	_{2.00s (± 0.77%)}	_{2.01s (± 0.75%)}	_~	_1.99s	_2.03s	_{p=0.170 n=6}
_{Bind Time}	_{1.01s (± 1.62%)}	_{1.00s (± 1.03%)}	_~	_0.99s	_1.02s	_{p=0.869 n=6}
_{Check Time}	_{6.25s (± 0.40%)}	_{6.24s (± 0.40%)}	_~	_6.21s	_6.28s	_{p=0.413 n=6}
_{Emit Time}	_{3.51s (± 1.06%)}	_{3.50s (± 0.38%)}	_~	_3.48s	_3.51s	_{p=0.605 n=6}
_{Total Time}	_{12.78s (± 0.35%)}	_{12.76s (± 0.23%)}	_~	_12.73s	_12.80s	_{p=0.332 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,439k (± 0.00%)}	_{470,423k (± 0.00%)}	_~	_470,410k	_470,453k	_{p=0.173 n=6}
_{Parse Time}	_{2.59s (± 0.66%)}	_{2.58s (± 0.79%)}	_~	_2.55s	_2.61s	_{p=0.408 n=6}
_{Bind Time}	_{1.00s (± 0.55%)}	_{0.99s (± 1.18%)}	_~	_0.98s	_1.01s	_{p=0.498 n=6}
_{Check Time}	_{16.63s (± 0.37%)}	_{16.59s (± 0.45%)}	_~	_16.47s	_16.68s	_{p=0.258 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.21s (± 0.25%)}	_{20.16s (± 0.41%)}	_~	_20.05s	_20.27s	_{p=0.226 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,192k (± 0.01%)}	_{512,468k (± 0.02%)}	_{+276k (+ 0.05%)}	_512,375k	_512,633k	_{p=0.005 n=6}
_{Parse Time}	_{3.26s (± 0.42%)}	_{3.27s (± 0.36%)}	_{+0.02s (+ 0.51%)}	_3.25s	_3.28s	_{p=0.048 n=6}
_{Bind Time}	_{1.55s (± 0.41%)}	_{1.55s (± 0.41%)}	_~	_1.54s	_1.56s	_{p=1.000 n=6}
_{Check Time}	_{2.77s (± 0.80%)}	_{2.79s (± 0.67%)}	_~	_2.76s	_2.81s	_{p=0.168 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.65s (± 0.42%)}	_{7.68s (± 0.23%)}	_~	_7.66s	_7.71s	_{p=0.108 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,379ms (± 2.05%)}	_{2,362ms (± 1.18%)}	_~	_2,331ms	_2,395ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{5,320ms (± 1.69%)}	_{5,353ms (± 1.52%)}	_~	_5,243ms	_5,433ms	_{p=0.936 n=6}
_{Req 3 - references}	_{332ms (± 1.46%)}	_{331ms (± 1.11%)}	_~	_326ms	_335ms	_{p=0.872 n=6}
_{Req 4 - navto}	_{277ms (± 0.54%)}	_{276ms (± 0.50%)}	_~	_274ms	_277ms	_{p=0.187 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 7.73%)}	_{85ms (± 8.46%)}	_~	_76ms	_90ms	_{p=0.204 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,469ms (± 0.66%)}	_{2,461ms (± 0.72%)}	_~	_2,437ms	_2,482ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{4,097ms (± 2.00%)}	_{4,100ms (± 1.77%)}	_~	_4,027ms	_4,196ms	_{p=0.688 n=6}
_{Req 3 - references}	_{338ms (± 1.42%)}	_{339ms (± 1.66%)}	_~	_332ms	_344ms	_{p=0.808 n=6}
_{Req 4 - navto}	_{283ms (± 0.36%)}	_{284ms (± 0.29%)}	_~	_282ms	_284ms	_{p=0.672 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 8.01%)}	_{82ms (± 7.78%)}	_~	_76ms	_88ms	_{p=0.859 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,600ms (± 0.14%)}	_{2,597ms (± 0.53%)}	_~	_2,576ms	_2,613ms	_{p=0.521 n=6}
_{Req 2 - geterr}	_{1,700ms (± 2.34%)}	_{1,684ms (± 2.53%)}	_~	_1,622ms	_1,732ms	_{p=0.630 n=6}
_{Req 3 - references}	_{114ms (± 9.21%)}	_{116ms (± 7.35%)}	_~	_106ms	_126ms	_{p=0.871 n=6}
_{Req 4 - navto}	_{365ms (± 0.67%)}	_{365ms (± 0.15%)}	_~	_364ms	_365ms	_{p=0.675 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{304ms (± 1.66%)}	_{307ms (± 0.49%)}	_~	_304ms	_308ms	_{p=0.091 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{151.95ms (± 0.17%)}	_{151.87ms (± 0.17%)}	_{-0.08ms (- 0.05%)}	_150.78ms	_154.16ms	_{p=0.001 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.56ms (± 0.14%)}	_{227.27ms (± 0.30%)}	_{-1.29ms (- 0.57%)}	_225.18ms	_231.65ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.10ms (± 0.15%)}	_{228.14ms (± 0.16%)}	_~	_226.47ms	_234.63ms	_{p=0.425 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.83ms (± 0.15%)}	_{227.81ms (± 0.16%)}	_~	_226.37ms	_232.82ms	_{p=0.379 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-20T00:38:53Z

@sheetalkamat Here are the results of running the user test suite comparing main and refs/pull/55790/merge:

Everything looks good!

typescript-bot · 2023-09-20T01:13:55Z

@sheetalkamat Here are the results of running the top-repos suite comparing main and refs/pull/55790/merge:

Everything looks good!

typescript-bot · 2023-09-20T01:57:01Z

@sheetalkamat Here are the results of running the top-repos suite comparing main and refs/pull/55790/merge:

Everything looks good!

…eFile

…only options that affect sourceFile

…wont change and ready to use.

DanielRosenwasser · 2023-09-20T17:57:01Z

Can you give some more details on what this change is regarding in the PR description? I can see baselines changing, but I'm not entirely sure what was wrong before.

sheetalkamat · 2023-09-20T17:58:00Z

@DanielRosenwasser Was just in process of writing

sheetalkamat · 2023-09-20T17:59:53Z

tests/baselines/reference/nodeColonModuleResolution.trace.json

@@ -1,4 +1,5 @@
 [
+    "Module 'ph' was resolved as locally declared ambient module in file '/a/b/node_modules/@types/node/ph.d.ts'.",


This is something to do with how we compile the program twice. which i dont understand clearly but when i run the scenario as "tsc" this trace is expected and was missing before.

sheetalkamat · 2023-09-20T18:00:22Z

...tRegistry/Caches-the-source-file-if-script-info-is-orphan,-and-orphan-script-info-changes.js

@@ -69,7 +69,7 @@ Info seq  [hh:mm:ss:mss] Open files:
 Info seq  [hh:mm:ss:mss] 	FileName: /user/username/projects/myproject/index.ts ProjectRootPath: undefined
 Info seq  [hh:mm:ss:mss] 		Projects: /user/username/projects/myproject/tsconfig.json
 DocumentRegistry::
-  Key:: undefined|undefined|undefined|undefined|false|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined|undefined
+  Key:: undefined|undefined|undefined|false|undefined|undefined|undefined|undefined|undefined|undefined


This just shortens the key because now many of the module resolution affecting options are not accounted in sourceFile sharing

jakebailey · 2023-09-20T18:59:06Z

Just to confirm my understanding, this moves properties off of SourceFile onto Program, such that the SourceFile can be shared more and has fewer props, and the diff is just all of the old places now calling the Program to get the same info, without any other behavior changes?

src/compiler/utilities.ts

andrewbranch · 2023-09-20T20:43:41Z

It seems like this could actually inflate memory usage (you can see a couple modest increases in some of the perf tests) when there are many programs with identical moduleResolution-related settings and some common dependencies. If the resolution-affecting options are the same between programs, those cases already had optimal SourceFile reuse but will now duplicate the resolutions (or at least maps of pointers to them) across each Program. Would it be valuable to move the resolutions not just to Program but to a shared, properly-keyed data structure similar to DocumentRegistry?

sheetalkamat · 2023-09-20T23:12:05Z

I was thinking as a next step we could try and use module resolution cache to get the result instead of storing it in the program but that needs some thinking( since in most cases resolution already exists in the cache)

storing on document registry would need so comparisons and invalidation logic that would lead to similar issue as I am trying to fix here (resolving type reference of auto type from different locations when two projects don’t specify type roots )

…#55790)

typescript-bot assigned sheetalkamat Sep 19, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 19, 2023

This comment was marked as resolved.

Sign in to view

sheetalkamat force-pushed the sourceFilesNotAffectedByModuleResolution branch from dc1a244 to 63226c2 Compare September 19, 2023 23:16

This comment was marked as resolved.

Sign in to view

sheetalkamat added 4 commits September 20, 2023 10:14

Remove resolvedModules and resolvedTypeReferenceDirectives from sourc…

72831ab

…eFile

Dont make sourceFiles sharing depend on moduleResolution options but …

0bb00ff

…only options that affect sourceFile

Simplify modified sourceFiles

2035d70

Processing resolutions is array since its already computed value and …

7be4b04

…wont change and ready to use.

sheetalkamat force-pushed the sourceFilesNotAffectedByModuleResolution branch from 6a43bc1 to 7be4b04 Compare September 20, 2023 17:28

sheetalkamat changed the title ~~[WIP] Source files not affected by module resolution~~ Source files not affected by all module resolution options Sep 20, 2023

sheetalkamat marked this pull request as ready for review September 20, 2023 17:37

sheetalkamat requested review from DanielRosenwasser, andrewbranch and jakebailey September 20, 2023 17:37

sheetalkamat commented Sep 20, 2023

View reviewed changes

jakebailey reviewed Sep 20, 2023

View reviewed changes

src/compiler/utilities.ts Show resolved Hide resolved

jakebailey approved these changes Sep 20, 2023

View reviewed changes

andrewbranch approved these changes Sep 20, 2023

View reviewed changes

sheetalkamat merged commit ec1414f into main Sep 20, 2023

sheetalkamat deleted the sourceFilesNotAffectedByModuleResolution branch September 20, 2023 23:45

sheetalkamat mentioned this pull request Sep 21, 2023

Incremental testing for program structure and resolutions and fixes #55814

Merged

snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023

Source files not affected by all module resolution options (microsoft…

62bdfca

…#55790)

JoshuaKGoldberg mentioned this pull request Oct 23, 2023

[api-extractor] ts.getResolvedModule with TypeScript 5.3 microsoft/rushstack#4404

Closed

anmolshres98 mentioned this pull request Jan 25, 2024

Bump dependencies and typescript version to latest iTwin/eslint-plugin#51

Merged

This was referenced Dec 5, 2024

ReferenceError: exports is not defined monounity/karma-typescript#625

Open

Convert e2e unit tests to use Jest firebase/firebase-js-sdk#8666

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source files not affected by all module resolution options #55790

Source files not affected by all module resolution options #55790

sheetalkamat commented Sep 19, 2023 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

sheetalkamat commented Sep 20, 2023

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023

typescript-bot commented Sep 20, 2023

Compiler

tsserver

Startup

typescript-bot commented Sep 20, 2023

typescript-bot commented Sep 20, 2023

typescript-bot commented Sep 20, 2023

DanielRosenwasser commented Sep 20, 2023 •

edited

Loading

sheetalkamat commented Sep 20, 2023

sheetalkamat Sep 20, 2023

sheetalkamat Sep 20, 2023

jakebailey commented Sep 20, 2023

andrewbranch commented Sep 20, 2023

sheetalkamat commented Sep 20, 2023

		@@ -1,4 +1,5 @@
		[
		"Module 'ph' was resolved as locally declared ambient module in file '/a/b/node_modules/@types/node/ph.d.ts'.",

Source files not affected by all module resolution options #55790

Source files not affected by all module resolution options #55790

Conversation

sheetalkamat commented Sep 19, 2023 • edited Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

sheetalkamat commented Sep 20, 2023

typescript-bot commented Sep 20, 2023 • edited Loading

typescript-bot commented Sep 20, 2023 • edited Loading

typescript-bot commented Sep 20, 2023 • edited Loading

typescript-bot commented Sep 20, 2023 • edited Loading

typescript-bot commented Sep 20, 2023 • edited Loading

typescript-bot commented Sep 20, 2023

typescript-bot commented Sep 20, 2023

Compiler

tsserver

Startup

typescript-bot commented Sep 20, 2023

typescript-bot commented Sep 20, 2023

typescript-bot commented Sep 20, 2023

DanielRosenwasser commented Sep 20, 2023 • edited Loading

sheetalkamat commented Sep 20, 2023

sheetalkamat Sep 20, 2023

Choose a reason for hiding this comment

sheetalkamat Sep 20, 2023

Choose a reason for hiding this comment

jakebailey commented Sep 20, 2023

andrewbranch commented Sep 20, 2023

sheetalkamat commented Sep 20, 2023

sheetalkamat commented Sep 19, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

DanielRosenwasser commented Sep 20, 2023 •

edited

Loading