Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(55796): JSDoc does not support @this when using an arrow function as method in class #55877

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #55796

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 26, 2023
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this change is appropriate given #55796 (comment)

@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 25, 2023
@sandersn
Copy link
Member

This PR adds an error for @this on an arrow function. It doesn't allow @this to change the type of this in the body of the arrow function.

@sandersn sandersn merged commit 5449489 into microsoft:main Oct 25, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

JSDoc does not support @this when using an arrow function as method in class
4 participants