Error on class fields accesses through super in JS files

[Andarist]

fixes #55884
follow up to #54056

[DanielRosenwasser]

Can you add a test for super["literalElementAccess"] as well?

Also, can you just add a test for super.b? I bet we have no test for super. on an accessor declaration at all.

[Andarist]

Can you add a test for super["literalElementAccess"] as well?

Good catch. It doesn't work correctly today (TS playground) even in TS files. For that reason - I'd say that this is a separate issue. I can look into it as well but I'd prefer to explore it separately.

Also, can you just add a test for super.b? I bet we have no test for super. on an accessor declaration at all.

Sure thing, just added it.

[DanielRosenwasser]

Can you add a test for this case in JavaScript as well and confirm it works?

// @checkJs: true

// @filename: foo.js
export class C {
  static blah1 = 123;
}
C.blah2 = 456;

export class D extends C {
  static {
    console.log(super.blah1);
    console.log(super.blah2);
  }
}

along with this:

// @checkJs: true

// @filename: foo.js
class C {
  constructor() {
    this.foo = () => {
      console.log("called arrow")
    }
  }
  foo() {
    console.log("called method")
  }
}

class D extends C {
  foo() {
    console.log("SUPER:");
    super.foo();
    console.log("THIS:");
    this.foo();
  }
}

const obj = new D();
obj.foo();
D.prototype.foo.call(obj);

[Andarist]

Can you add a test for this case in JavaScript as well and confirm it works?

Added both - I had to fix one of them 😉

[jakebailey]

@typescript-bot test top100
@typescript-bot user test this

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 23ec307. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 23ec307. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55892/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Unknown failure"
• 2 instances of "Package install failed"

Otherwise...

Everything looks good!

[DanielRosenwasser]

Suggested change

	export function isClassFieldAndNotAutoAccessor(node: Declaration): boolean {
	export function isClassInstanceProperty(node: Declaration): boolean {

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55892/merge:

Everything looks good!

[DanielRosenwasser]

Let's get this in for 5.3 beta and do the rename after.