Additional Types cleanup #5719
Merged
Additional Types cleanup #5719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on and a 'this' type. Needed for transforms
… 'Object' for now.
|
👍 |
DanielRosenwasser
added
Breaking Change
| @@ -726,6 +727,7 @@ namespace ts { | |||
| // @kind(SyntaxKind.StringKeyword) | |||
| // @kind(SyntaxKind.SymbolKeyword) | |||
| // @kind(SyntaxKind.VoidKeyword) | |||
| // @kind(SyntaxKind.ThisType) | |||
There was a problem hiding this comment.
What about string literal types?
There was a problem hiding this comment.
I think there would need to be a StringLiteralType kind and a StringLiteral kind, just like how there's ThisType and ThisKeyword. So maybe a followup PR?
There was a problem hiding this comment.
@DanielRosenwasser, @weswigham: I primarily need this to disambiguate this during tree transformations. I have no such need for disambiguation for string literal types. I may have a follow-up PR for this at some point to achieve consistency, but its not as high of a priority.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThisTypesyntax kind, which will be needed by tree transforms to disambiguatethisin a type position fromthisin an expression position.thistypes in conjunction with--emitDecoratorMetadata. It now prints "Object" rather than crashing the compiler with a debug assertion.Supports #5595.