-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[experiment] make tsc use the public API #57703
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@typescript-bot perf test this |
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
Wow, that's like 3-10% slower. |
👀 |
Are you talking about not having the |
In my case I didn’t care about perf - just that the same tsconfig produces exactly the same behavior and compiled output as the same tsconfig provided to tsc. For any arbitrary config. I feel like I got close, but I’m sure there are a lot of edge cases I missed. |
4d9c210
to
ab21872
Compare
Rebased this PR now that #55326 is in; to test out the services perf, this PR can be cherry-picked in elsewhere to run perf tests. |
ab21872
to
edf238f
Compare
#58045 is in, so retesting to gauge how much is left: @typescript-bot perf test this faster |
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@typescript-bot perf test this faster |
Starting jobs; this comment will be updated as builds start and complete.
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
Wacky test built on #55326 which makes
tsc
use the public API. Curious how bad the perf of this is.The below represents effectively the smallest our package is going to get without splitting it into multiple packages.
Overall package size
Files
lib/tsc.js