Allow references to the global Symbol in computed property names under isolatedDeclarations #58771
+120
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r isolatedDeclarations
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
approved these changes
Jun 4, 2024
|
Is this something we should backport to 5.5? |
|
|
Perhaps in 5.5.4? Also we just stumbled on some code today that could really use something like #58829, since it uses custom created |
|
I'll discuss with others whether it's a good idea to backport, but in the meantime let's just kick it off. @typescript-bot cherry-pick this to release-5.5 |
typescript-bot
pushed a commit
that referenced
this pull request
Jul 21, 2024
…r isolatedDeclarations (#58771)
|
Hey, @DanielRosenwasser! I've created #59378 for you. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jul 22, 2024
…e-5.5 (#59378) Co-authored-by: Wesley Wigham <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, they must look like
Symbol.somethingorglobalThis.Symbol.something, and in the first case, that first identifier must refer exactly to the globalSymbolvalue (or not resolve at all, in which case it's the missing global by default). In the second,globalThismust exactly refer to the globalglobalThis.This should allow the common cases like
Symbol.iteratormembers and the like, without allowing complicated ones that might not be right like imports that refer to arbitrary maybe-symbol names.