do not add 'this' type for classes that considered safe (use 'this' only in property\element access expressions) #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly in property\element access expressions)
| return true; | ||
| } | ||
| for (const node of nodes) { | ||
| if (!isIndependentHeritageClauseElement(node, /*classSymbol*/ undefined)) { |
There was a problem hiding this comment.
Might be worth merging in Ron's every from the transforms branch and making classSymbol optional so you can just say
return !nodes || !every(nodes, isIndependentHeritageClauseElement)
|
@vladima, can you update this change and merge it in? |
|
@vladima can you update this change? |
|
Thanks for your contribution. This PR has failing CI tests and can not be merged in at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to merge this code in, please open a new PR that has been merged and rebased with the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a set of perf issues mostly uncovered by rxjs