Searching icons by tags #1562
Merged
Searching icons by tags #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added tags to 400 icons and didn't (couldn't) add tags to all >1400 icons. It takes too much time and patience. 😅 |
|
🔥🔥🔥 |
|
/azp run |
karkarl
approved these changes
Jul 19, 2024
|
Tnx @AndrewKeepCoding for this great pr.
|
3 tasks
marcelwgn
pushed a commit
that referenced
this pull request
Jan 12, 2025
<!--- Provide a general summary of your changes in the Title above --> ## Description This update adds tags to the icons listed in `IconsData.json`, improving the searchability of icons on the iconography page. The only change is the addition of tags to the `IconsData.json` file. **How the Tags Were Chosen:** - For many icons, the tags are derived from those used in the [Fluent UI System Icons](https://github.com/microsoft/fluentui-system-icons.git) project, particularly for common icons. - For most icons and icons that not included in the Fluent UI System Icons, tags were added through a combination of personal effort and assistance from AI. ## Motivation and Context - Many icons currently lack tags, limiting the effectiveness of this feature. Adding tags to all icons ensures that the search functionality is fully utilized, making it easier for users to find the icons they need efficiently. This enhancement aligns with the goal of providing a seamless and user-friendly experience. - Closes #1705 - Related to #1544, #1562 and #1693 ## How Has This Been Tested? **Manually tested** ## Screenshots   ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1544.
This PR will enable searching icons based on tags on the Iconography page. Icon tags are assigned on the IconsData.json file.
Motivation and Context
The current icon searching is based only on the icon name or its code. Some icon's names are not very intuitive, or some icons can represent several things. So, to get an icon code and if you don't know the icon name, you need to search it manually by scrolling through more than 1400 icons.
How Has This Been Tested?
Tested on the VS.
Screenshots (if appropriate):
Types of changes