Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitView Sample -> fix the mismatch between rendered content and source code #1617

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Zakariathr22
Copy link
Contributor

Description

A simple update to resolve discrepancies between the rendered content and the displayed source code, the only change is:

  • Remove the code that does not match from the displayed source code (SplitViewPage.xaml).

Motivation and Context

How Has This Been Tested?

Manually Tested

Screenshots:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Zakariathr22 Zakariathr22 marked this pull request as draft August 23, 2024 19:22
@Zakariathr22 Zakariathr22 marked this pull request as ready for review August 23, 2024 19:22
@karkarl
Copy link
Collaborator

karkarl commented Sep 27, 2024

/azp run

1 similar comment
@karkarl
Copy link
Collaborator

karkarl commented Nov 13, 2024

/azp run

@karkarl karkarl merged commit 5f46afa into microsoft:main Nov 13, 2024
2 checks passed
@karkarl
Copy link
Collaborator

karkarl commented Nov 13, 2024

@Zakariathr22 Thanks so much again for opening the series of PR's. Glad to have these merged in finally after an internal pipeline fiasco!

@Zakariathr22
Copy link
Contributor Author

@karkarl Thanks so much for the time and effort on the review and for approving my ideas! 🙏 Excited to keep contributing! 🚀

@Zakariathr22 Zakariathr22 deleted the split-view-mismatch branch December 2, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants