Delegate to OS RegFreeWinRT when available (>=24H1) #4728

DrusTheAxe · 2024-09-17T21:18:44Z

Delegate to OS RegFreeWinRT when available (>=24H1)

Don't detour APIs to our Undocked Reg-Free WinRT implementation if the OS supports Reg-Free WinRT (>=24H1)

https://task.ms/47326505

DrusTheAxe · 2024-09-17T21:19:11Z

/azp run

azure-pipelines · 2024-09-17T21:19:25Z

Azure Pipelines successfully started running 1 pipeline(s).

DrusTheAxe · 2024-10-03T16:29:11Z

/azp run

azure-pipelines · 2024-10-03T16:29:26Z

Azure Pipelines successfully started running 1 pipeline(s).

…se). Added -CheckTAEFService -CheckVisualStudio -CheckDeveloperMode to 'DevCheck: Setup/Verify developer environment' to cover the missing checks

DrusTheAxe · 2024-10-07T05:39:20Z

/azp run

azure-pipelines · 2024-10-07T05:39:34Z

Azure Pipelines successfully started running 1 pipeline(s).

DrusTheAxe · 2024-10-07T17:36:58Z

/azp run

azure-pipelines · 2024-10-07T17:37:13Z

Azure Pipelines successfully started running 1 pipeline(s).

DrusTheAxe · 2024-10-07T20:54:26Z

/azp run

azure-pipelines · 2024-10-07T20:55:04Z

Azure Pipelines successfully started running 1 pipeline(s).

…S RFW on >=24H1 (where DynDep will delegate to OS DynDep). Fixed some bad sprintfs. Changed Is*Supported(PackageDeploymentFeature::PackageUriScheme_ms_uup) to use the Is*Supported function

DrusTheAxe · 2024-10-08T02:14:43Z

/azp run

azure-pipelines · 2024-10-08T02:14:57Z

Azure Pipelines successfully started running 1 pipeline(s).

DrusTheAxe · 2024-10-08T07:50:54Z

/azp run

azure-pipelines · 2024-10-08T07:51:08Z

Azure Pipelines successfully started running 1 pipeline(s).

DrusTheAxe · 2024-10-08T17:07:13Z

/azp run

azure-pipelines · 2024-10-08T17:07:28Z

Azure Pipelines successfully started running 1 pipeline(s).

dev/Common/IsWindowsVersion.h

wcheng-msft

DrusTheAxe · 2024-11-21T19:13:56Z

/azp run

azure-pipelines · 2024-11-21T19:14:11Z

Azure Pipelines successfully started running 1 pipeline(s).

DrusTheAxe · 2024-11-22T05:48:28Z

/azp run

azure-pipelines · 2024-11-22T05:48:42Z

Azure Pipelines successfully started running 1 pipeline(s).

DrusTheAxe · 2024-11-23T06:46:20Z

Eyeballed 24H2 Run TAEF Tests logs verifying success:

DynamicDependency_Test_Win32.dll Summary: Total=71, Passed=71, Failed=0, Blocked=0, Not Run=0, Skipped=0

DynamicDependency_Test_WinRT.dll Summary: Total=36, Passed=36, Failed=0, Blocked=0, Not Run=0, Skipped=0

Fire in the hole!

jonwis · 2024-11-23T07:18:43Z

test/ApplicationData/ApplicationDataTests.cpp

@@ -237,15 +239,23 @@ namespace Test::ApplicationData::Tests
        TEST_METHOD(MachineFolderAndPath_Main_NotSupported)
        {
            winrt::hstring packageFamilyName{ Main_PackageFamilyName };
+WEX::Logging::Log::Comment(WEX::Common::String().Format(L"A1: %ls", packageFamilyName.c_str()));


Nit, too late I guess - questionable indentation?

Actually leftover debugging code. Harmless but should go. I'll clean it up in a follow up PR.

jonwis · 2024-11-23T07:20:31Z

dev/Common/IsWindowsVersion.h

@@ -33,30 +33,35 @@ inline bool IsExportPresent(

 inline bool IsWindows10_19H1OrGreater()
 {
-    // GetPackageInfo2() added to kernelbase.dll in NTDDI_WIN10_19H1 (aka 19H1)
+    // GetPackageInfo2() added to kernelbase.dll in 19H1 (aka NTDDI_WIN10_19H1)
    return IsExportPresent(L"kernelbase.dll", "GetPackageInfo2");


Here's where Gov would ask you to probe for specific features, rather than a blanket "am I on Win10 20H1"

This is used sparingly, primarily where we need to detect downlevel behavior or implementation details that has no overt advertisement or detection mechanism. But now I'm curious. I'll do an all up review and see if some of these can be changed to more direct feature-probing-for-feature-behavior. Thanks for sparking the itch

This reverts commit 6839e95.

…4935) This reverts commit 6839e95.

…4728)" …" This reverts commit c088336.

…#4935) This reverts commit c088336.

* Delegate to OS RegFreeWinRT when available (>=19H1) * Changed DevCheck to emit expected TAEF version found (not just -Verbose). Added -CheckTAEFService -CheckVisualStudio -CheckDeveloperMode to 'DevCheck: Setup/Verify developer environment' to cover the missing checks * Removed redundant checks done later in pipelines * Added diagnostics for troubleshooting. Fixed compiler warnings * More debuggery * Added IsWindows11_24H2OrGreater(). Changed URFW to only delegate to OS RFW on >=24H1 (where DynDep will delegate to OS DynDep). Fixed some bad sprintfs. Changed Is*Supported(PackageDeploymentFeature::PackageUriScheme_ms_uup) to use the Is*Supported function * More diagnostics * Bumped TAEF to latest version 10.95.240918004 * Moar debugging * Fixes * Minor fix * Removed previous interim block disabling Dynamic Dependencies delegation to OS Dynamic Dependencies. Let's take it for a spin and see how it handles... * Fixed DevCheck not getting VS' path thus not checking VS stuff * Split IsReady tests into RestrictedUser vs ElevatedUser * Fix mis-tagging of TAEF properties (though according to TAEF folks TEST_CLASS_PROPERTY is treated same as TEST_METHOD_PROPERTY if inside a BEGIN/END_METHOD_PROPERTIES() block because it's been a common mistake, so TAEF now treats it effectively as TEST_PROPERTY() scoped to the surrounding BEGIN/END_*_PROPERTY() * DevCheck -SyncDependencies update * Removed FrameworkUdk references in packages.config. Added Build Dependencies in WindowsAppRuntime.sln for anything using FrUdk on the Microsoft.FrameworkUdk.PackageReferences.csproj as th SexyNewfangledWay(TM) to restore FrameworkUdk (when necessary) * PackageManager test tweaks * Expanded enablement for further test investigation * Fixed test to account for OS vs WinAppSDK error detection * Fixed RegisterNewerIfAvailable * Removed 22H2 testing * Fixed h/cpp mismatch * Removed non-existent GUID/reference (bad merge?) * Fixed test bug not handling all behavior coming out of OS API * Fixed tests * Updated WinRT tests akin to Win32

…4935) This reverts commit 6839e95.

…#4935) (#4949) * Reapply "Delegate to OS RegFreeWinRT when available (>=24H1) (#4728)" (#4935) This reverts commit c088336. * Added missing dependencies for OAuth2ManagerTests * Expanded tests * Modified IsSupported with temporary debugging hack to expedite testing. Added local hackery for Architectures=None (but is it needed?) * Removed debug hackery * Test fixes * More test fiddling * Microsoft.Windows.BadgeNotifications.Projection project is missing a build-order dependency on WindowsAppRuntime_DLL so depending on timing and beefy machine it can try to build before the dependency is built and boom :-( * Removed redundant Import * Fixed bad merge * Fixed WinAppSDK framework package family name construction in GetFrameworkPackageFamilyName() [MddBootstrap.cpp]. This is used in production when delegating to OS DynDep but not when using WinAppSDK DynDep (and test support used different codepath). That's why test packages with blah-major.minor... package names worked in test and on Win10 but not when delegating to OS DynDep on Win11. Added additional test tools to aid verification and debugging (now and in any future changes). * Fixed DevCheck -CheckDependencies if packages.config has no <package> elements. Ran DevCheck -SyncDependencies to update stale dependencies * Fix test framework package Name from name-major.minor to name.major.minor * Workaround Windows bug https://task.ms/54835001 where IsPackage*ReadyOrNewerAvailable() doesn't correctly handle ProcessorArchitectureFilter=None * Ran devcheck -syncdependencies * Fixed failing PackageManagementTests * Updated dependnecies via DevCheck -SyncDependencies. Removed unused Microsoft.Windows.SDK.BuildTools and Microsoft.WindowsAppSDK references in WindowsAppRuntime_UniversalBGTaskDLL's packages.config. Removed dead readme.txt in WindowsAppRuntime_UniversalBGTaskDLL projectdir (artifact of VS File/NewProject...). * Updated link to latest SDK rev * Fixed dependencies (syntax and usage * Put WindowsAppRuntime_UniversalBGTaskDLL back to what's in main. No idea why that works but changing it -- in what should be innocuous ways -- breaks local + pipeline builds. Deferring that problem to Will Thant in its own right (not relevant to my changes) * Fixed hardcoded versions in OAuthTestApp.vcxproj (wasn't using version macro) * Fixed more bad projects - Import Microsoft.Cpp.Default.props not at the top, .. pathing to nugets and hardwired nuget versions * Fixed WindowsAppRuntime_UniversalBGTaskDLL - Import Microsoft.Cpp.Default.props not at top of file, not using $(NugetPackageDirectory) for pathing to nugets, hardwired versions for nugets, unnecessary Microsoft.WindowsAppSDK in packages.config * Added -ShowSystemInfo (default=$true) to Testall so test run output includes basic system info * Fixed up test Main+Singleton+DDLM naming/constants * Fixed bug in package name constant * Added missing project dependencies. Updated ConfigurationManager to build test packages on ARM64 too (some were only build for x64|x86) * Fixed bad merge * Fixed a bad merge * Removed temporary debugging code * Some test packages lacked ARM64 support, plus those and others weren't getting built for ARM64. And some projects built not-ARM64 for ARM64. Mostly fixed. Some test projects lack ARM64 support but not touched as not blocking here and overdue already; they can (and will) be handled in a separate follow up effort * Fixed one more ARM configuration manager misconfiguration --------- Co-authored-by: Kyaw Thant <[email protected]>

…ailable (>=24H1) (#5112) * Reapply "Delegate to OS RegFreeWinRT when available (>=24H1) (#4728)" (#4935) (#4949) * Reapply "Delegate to OS RegFreeWinRT when available (>=24H1) (#4728)" (#4935) This reverts commit c088336. * Added missing dependencies for OAuth2ManagerTests * Expanded tests * Modified IsSupported with temporary debugging hack to expedite testing. Added local hackery for Architectures=None (but is it needed?) * Removed debug hackery * Test fixes * More test fiddling * Microsoft.Windows.BadgeNotifications.Projection project is missing a build-order dependency on WindowsAppRuntime_DLL so depending on timing and beefy machine it can try to build before the dependency is built and boom :-( * Removed redundant Import * Fixed bad merge * Fixed WinAppSDK framework package family name construction in GetFrameworkPackageFamilyName() [MddBootstrap.cpp]. This is used in production when delegating to OS DynDep but not when using WinAppSDK DynDep (and test support used different codepath). That's why test packages with blah-major.minor... package names worked in test and on Win10 but not when delegating to OS DynDep on Win11. Added additional test tools to aid verification and debugging (now and in any future changes). * Fixed DevCheck -CheckDependencies if packages.config has no <package> elements. Ran DevCheck -SyncDependencies to update stale dependencies * Fix test framework package Name from name-major.minor to name.major.minor * Workaround Windows bug https://task.ms/54835001 where IsPackage*ReadyOrNewerAvailable() doesn't correctly handle ProcessorArchitectureFilter=None * Ran devcheck -syncdependencies * Fixed failing PackageManagementTests * Updated dependnecies via DevCheck -SyncDependencies. Removed unused Microsoft.Windows.SDK.BuildTools and Microsoft.WindowsAppSDK references in WindowsAppRuntime_UniversalBGTaskDLL's packages.config. Removed dead readme.txt in WindowsAppRuntime_UniversalBGTaskDLL projectdir (artifact of VS File/NewProject...). * Updated link to latest SDK rev * Fixed dependencies (syntax and usage * Put WindowsAppRuntime_UniversalBGTaskDLL back to what's in main. No idea why that works but changing it -- in what should be innocuous ways -- breaks local + pipeline builds. Deferring that problem to Will Thant in its own right (not relevant to my changes) * Fixed hardcoded versions in OAuthTestApp.vcxproj (wasn't using version macro) * Fixed more bad projects - Import Microsoft.Cpp.Default.props not at the top, .. pathing to nugets and hardwired nuget versions * Fixed WindowsAppRuntime_UniversalBGTaskDLL - Import Microsoft.Cpp.Default.props not at top of file, not using $(NugetPackageDirectory) for pathing to nugets, hardwired versions for nugets, unnecessary Microsoft.WindowsAppSDK in packages.config * Added -ShowSystemInfo (default=$true) to Testall so test run output includes basic system info * Fixed up test Main+Singleton+DDLM naming/constants * Fixed bug in package name constant * Added missing project dependencies. Updated ConfigurationManager to build test packages on ARM64 too (some were only build for x64|x86) * Fixed bad merge * Fixed a bad merge * Removed temporary debugging code * Some test packages lacked ARM64 support, plus those and others weren't getting built for ARM64. And some projects built not-ARM64 for ARM64. Mostly fixed. Some test projects lack ARM64 support but not touched as not blocking here and overdue already; they can (and will) be handled in a separate follow up effort * Fixed one more ARM configuration manager misconfiguration --------- Co-authored-by: Kyaw Thant <[email protected]> * Bootstrapper missed an update resulting in FindDDLMViaEnumeration() looking for DDLM packages named ...ddlm-version... rather than ...ddlm.version... Local tests passed as they were named with dash but product DDLMs are named with . causing toplevel tests using production packages to fail. Fixed and updated local tests to use naming consistent with product to prevent future confusion (#5106) --------- Co-authored-by: Kyaw Thant <[email protected]>

Delegate to OS RegFreeWinRT when available (>=19H1)

72d8853

DrusTheAxe added the area-UndockedRegFreeWinRT label Sep 17, 2024

DrusTheAxe added this to the 1.7 milestone Sep 17, 2024

DrusTheAxe self-assigned this Sep 17, 2024

microsoft-github-policy-service bot added the needs-triage label Sep 17, 2024

Merge branch 'main' into user/drustheaxe/no-urfw

b8e57f0

Changed DevCheck to emit expected TAEF version found (not just -Verbo…

1877de9

…se). Added -CheckTAEFService -CheckVisualStudio -CheckDeveloperMode to 'DevCheck: Setup/Verify developer environment' to cover the missing checks

DrusTheAxe added 2 commits October 7, 2024 10:00

Removed redundant checks done later in pipelines

f41ce39

Added diagnostics for troubleshooting. Fixed compiler warnings

f59671c

More debuggery

a7650e5

Added IsWindows11_24H2OrGreater(). Changed URFW to only delegate to O…

bfb4623

…S RFW on >=24H1 (where DynDep will delegate to OS DynDep). Fixed some bad sprintfs. Changed Is*Supported(PackageDeploymentFeature::PackageUriScheme_ms_uup) to use the Is*Supported function

More diagnostics

921330a

DrusTheAxe mentioned this pull request Oct 8, 2024

Variant of user/drustheaxe/no-urfw to test a pipeline issue #4785

Closed

Bumped TAEF to latest version 10.95.240918004

1f7d875

DrusTheAxe requested review from joshusto, letao-msft and sachintaMSFT November 14, 2024 01:06

DrusTheAxe changed the title ~~Delegate to OS RegFreeWinRT when available (>=19H1)~~ Delegate to OS RegFreeWinRT when available (>=24H1) Nov 14, 2024

wcheng-msft reviewed Nov 14, 2024

View reviewed changes

dev/Common/IsWindowsVersion.h Show resolved Hide resolved

wcheng-msft reviewed Nov 14, 2024

View reviewed changes

dev/Common/IsWindowsVersion.h Show resolved Hide resolved

wcheng-msft approved these changes Nov 14, 2024

View reviewed changes

DrusTheAxe added 2 commits November 21, 2024 10:04

Fixed test bug not handling all behavior coming out of OS API

7445541

Fixed tests

4653258

Updated WinRT tests akin to Win32

96323ec

DrusTheAxe merged commit 6839e95 into main Nov 23, 2024
26 checks passed

DrusTheAxe deleted the user/drustheaxe/no-urfw branch November 23, 2024 06:46

jonwis reviewed Nov 23, 2024

View reviewed changes

kythant added a commit that referenced this pull request Dec 4, 2024

Revert "Delegate to OS RegFreeWinRT when available (>=24H1) (#4728)"

2964a58

This reverts commit 6839e95.

kythant added a commit that referenced this pull request Dec 4, 2024

Revert "Delegate to OS RegFreeWinRT when available (>=24H1) (#4728)" (#…

c088336

…4935) This reverts commit 6839e95.

DrusTheAxe added a commit that referenced this pull request Dec 10, 2024

Revert "Revert "Delegate to OS RegFreeWinRT when available (>=24H1) (#…

fc03591

…4728)" …" This reverts commit c088336.

DrusTheAxe added a commit that referenced this pull request Dec 10, 2024

Reapply "Delegate to OS RegFreeWinRT when available (>=24H1) (#4728)" (…

04c7ea4

…#4935) This reverts commit c088336.

This was referenced Dec 10, 2024

Reapply "Delegate to OS RegFreeWinRT when available (>=24H1) (#4728)" (#4935) #4949

Merged

48525090 Delegate DynamicDependencies to OS API when available #4136

Closed

codendone pushed a commit that referenced this pull request Jan 10, 2025

Revert "Delegate to OS RegFreeWinRT when available (>=24H1) (#4728)" (#…

5fe7794

…4935) This reverts commit 6839e95.

DrusTheAxe mentioned this pull request Feb 6, 2025

[WASDK 1.7] Delegate to OS RegFreeWinRT + DynamicDependencies when available (>=24H1) #5112

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delegate to OS RegFreeWinRT when available (>=24H1) #4728

Delegate to OS RegFreeWinRT when available (>=24H1) #4728

DrusTheAxe commented Sep 17, 2024 •

edited

Loading

DrusTheAxe commented Sep 17, 2024

azure-pipelines bot commented Sep 17, 2024

DrusTheAxe commented Oct 3, 2024

azure-pipelines bot commented Oct 3, 2024

DrusTheAxe commented Oct 7, 2024

azure-pipelines bot commented Oct 7, 2024

DrusTheAxe commented Oct 7, 2024

azure-pipelines bot commented Oct 7, 2024

DrusTheAxe commented Oct 7, 2024

azure-pipelines bot commented Oct 7, 2024

DrusTheAxe commented Oct 8, 2024

azure-pipelines bot commented Oct 8, 2024

DrusTheAxe commented Oct 8, 2024

azure-pipelines bot commented Oct 8, 2024

DrusTheAxe commented Oct 8, 2024

azure-pipelines bot commented Oct 8, 2024

wcheng-msft left a comment

DrusTheAxe commented Nov 21, 2024

azure-pipelines bot commented Nov 21, 2024

DrusTheAxe commented Nov 22, 2024

azure-pipelines bot commented Nov 22, 2024

DrusTheAxe commented Nov 23, 2024

jonwis Nov 23, 2024

DrusTheAxe Nov 23, 2024

jonwis Nov 23, 2024

DrusTheAxe Nov 23, 2024

Delegate to OS RegFreeWinRT when available (>=24H1) #4728

Delegate to OS RegFreeWinRT when available (>=24H1) #4728

Conversation

DrusTheAxe commented Sep 17, 2024 • edited Loading

DrusTheAxe commented Sep 17, 2024

azure-pipelines bot commented Sep 17, 2024

DrusTheAxe commented Oct 3, 2024

azure-pipelines bot commented Oct 3, 2024

DrusTheAxe commented Oct 7, 2024

azure-pipelines bot commented Oct 7, 2024

DrusTheAxe commented Oct 7, 2024

azure-pipelines bot commented Oct 7, 2024

DrusTheAxe commented Oct 7, 2024

azure-pipelines bot commented Oct 7, 2024

DrusTheAxe commented Oct 8, 2024

azure-pipelines bot commented Oct 8, 2024

DrusTheAxe commented Oct 8, 2024

azure-pipelines bot commented Oct 8, 2024

DrusTheAxe commented Oct 8, 2024

azure-pipelines bot commented Oct 8, 2024

wcheng-msft left a comment

Choose a reason for hiding this comment

DrusTheAxe commented Nov 21, 2024

azure-pipelines bot commented Nov 21, 2024

DrusTheAxe commented Nov 22, 2024

azure-pipelines bot commented Nov 22, 2024

DrusTheAxe commented Nov 23, 2024

jonwis Nov 23, 2024

Choose a reason for hiding this comment

DrusTheAxe Nov 23, 2024

Choose a reason for hiding this comment

jonwis Nov 23, 2024

Choose a reason for hiding this comment

DrusTheAxe Nov 23, 2024

Choose a reason for hiding this comment

DrusTheAxe commented Sep 17, 2024 •

edited

Loading