Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower WindowsAppSDK min version to be 17763 #234

Merged
merged 5 commits into from
Sep 21, 2022

Conversation

michael-hawker
Copy link
Contributor

Fixes #233

This is needed to lower the min version of the Windows Community Toolkit to match the min version of the WindowsAppSDK 1.x releases of 17763 (instead of 18362 as the original Project Reunion releases were). See issue for more details.

Built package locally (added instructions to readme) and tested in a new Windows App SDK 1.1.x project targeting 17763. Example in readme worked without issue.

Commented out designtools dlls from WinUI nuspec as wouldn't build (and no designer in WinUI, so assume that's why they didn't work?)

FYI @DVaughan @azchohfi, know you've moved to other work now, but if you can spare a minute for a quick glance, would be great!

@DVaughan
Copy link
Contributor

I'm not sure about the design-time assembly failures. In the absence of a WinUI designer I would have thought that those would be ignored. There might be something that needs disabling in the interim. Adding @mgoertz-msft & @bhavyaus

@mgoertz-msft
Copy link
Member

The designtools DLLs are used by the XAML editor as well for things like EditorBrowsable, etc. Given that they built successfully before we should probably figure out why they don't anymore.

@michael-hawker
Copy link
Contributor Author

I do see now comparing in NuGet Package Explorer that the DesignTools assemblies were there:

image

So, I'm not sure why that was failing locally for me for them to be found during the build. I'll try taking another look.

@michael-hawker
Copy link
Contributor Author

Alright I was able to build it all locally:

image

Not too sure what my issue was the first time. I guess something in my environment hadn't built the other part. I did a git clean, and rebuilt and things worked.

Would be good to document the msbuild step that VS is doing so it can be built entirely on the commandline as well vs. having to build all in VS.

Will commit here in a minute with the uncommenting of the nuspec file.

Removes invalid design dlls (no designer for WinUI 3) that caused local build to fail
bump version number
README.md Outdated
For WinUI:

- Run `msbuild /t:Pack src\BehaviorsSDKManaged\Microsoft.Xaml.Interactivity.WinUI\Microsoft.Xaml.Interactivity.WinUI.csproj`
- *(Optional)* Add /p:TimestampPackage=true to include the timestamp in the NuGet package version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be /p:TimestampPackage=true?

README.md Outdated Show resolved Hide resolved
@mgoertz-msft mgoertz-msft merged commit 0740084 into microsoft:winui Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants