-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enzyme replacement in test files- PR 1 of 6 for part 2 of 3 #7207
chore: Enzyme replacement in test files- PR 1 of 6 for part 2 of 3 #7207
Conversation
…accessibility-insights-web into enzyme_replacement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small nits and then this looks good to go!
src/tests/unit/tests/DetailsView/components/left-nav/details-view-left-nav.test.tsx
Outdated
Show resolved
Hide resolved
General comment: Having a series of PR's titled "... user story ABC", "... user story DEF", "...user story GHI", etc., can be useful when tracking the implementation of the work, but once the PR is merged, its value drops dramatically, especially if the engineering system ever becomes unavailable. As an alternative, may I suggest a slightly different approach, with the intent to make it possible to understand the change even without access to the ADO system (which will be the case for any external contributor, or even internal contributors should we later change engineering systems)
So a specific one of these tasks might have a title of "chore: Enzyme replacement in test files - part 3 of 12". The description might include something like: Files in scope for this PR:
|
Details
Enzyme replacement in files under src/tests/unit/tests/DetailsView/components
Motivation
Existing story: User Story 2136480
Replaced the use of Enzyme in the below files:
Code coverage before and after codeshift checked and it is same.
Context
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.