Removing finish reason. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily involves the removal of the
AIChatFinishReasontype and its usages across multiple files. This type was previously used to denote the reason for the completion of a chat, but it seems that this functionality is no longer needed.Here are the most important changes:
Removal of
AIChatFinishReasonfrom exports and imports:samples/backend/js/expressjs/src/routes/chat.ts: Removed the import ofAIChatFinishReason.sdk/js/packages/client/src/index.ts: Removed the export ofAIChatFinishReason.sdk/js/packages/client/src/model/index.ts: Removed the export ofAIChatFinishReason.Removal of
AIChatFinishReasonfrom type definitions and interfaces:sdk/js/packages/client/src/model/model.ts: Removed theAIChatFinishReasontype definition and its usage inAIChatCompletionandAIChatCompletionDeltainterfaces. [1] [2]spec/models.tsp: Removed theAIChatFinishReasonenum and its usage inAIChatCompletionandAIChatCompletionDeltamodels. [1] [2] [3]Removal of
AIChatFinishReasonfrom function implementations:samples/backend/js/expressjs/src/routes/chat.ts: Removed thefinishReasonfield from theAIChatCompletionobject in two different post endpoints. [1] [2]These changes simplify the codebase by removing an unnecessary type and its usages.