Allowing endpoints that don't end in '/' #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes significant changes to the
AIChatProtocolClient
class in thesdk/js/packages/client/src/client.ts
file. The changes primarily focus on the way URLs are handled within the client. A new functionsplitURL
is introduced to parse the URL into origin and path components. TheAIChatProtocolClient
constructor and methods are then updated to use these separate components instead of the absolute URL.URL Handling Changes:
sdk/js/packages/client/src/client.ts
: Introduced a new functionsplitURL
which takes a URL string as input and returns a tuple containing the origin and path.sdk/js/packages/client/src/client.ts
: Updated theAIChatProtocolClient
constructor to use thesplitURL
function to parse the endpoint into origin and path. The path is stored in a newbasePath
member variable. ThegetClient
function is then called with the origin instead of the absolute endpoint.sdk/js/packages/client/src/client.ts
: Updated thepost
method call in theclient.path
function to usethis.basePath
instead of the root path ("/").sdk/js/packages/client/src/client.ts
: Similarly, updated thepost
method call in theclient.path
function within theasStream
function to usethis.basePath
instead of the root path ("/stream").