Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding file support #59

Merged
merged 18 commits into from
Aug 13, 2024
Merged

Adding file support #59

merged 18 commits into from
Aug 13, 2024

Conversation

glecaros
Copy link
Member

@glecaros glecaros commented Jun 20, 2024 •
edited
Loading

No description provided.

@glecaros glecaros force-pushed the glecaros/file_upload branch from 8e19305 to 3347390 Compare June 20, 2024 23:33
@glecaros glecaros force-pushed the glecaros/file_upload branch from f12a55c to e442afe Compare June 25, 2024 17:28
@glecaros glecaros force-pushed the glecaros/file_upload branch from 2ed25f3 to 0449e87 Compare June 25, 2024 21:47
@glecaros glecaros force-pushed the glecaros/file_upload branch from 89f9657 to 1d89403 Compare June 25, 2024 21:53
@glecaros glecaros marked this pull request as ready for review June 25, 2024 21:55
pamelafox
pamelafox reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add to the samples/README for Python-Quart?

pamelafox
pamelafox approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a browser test in Chrome/Safari, Python backend + frontend worked.

glecaros and others added 9 commits August 12, 2024 13:29
@glecaros @stephentoub
Update samples/backend/csharp/Controllers/ChatController.cs
49dbaaf 
Co-authored-by: Stephen Toub <[email protected]>
@glecaros @stephentoub
Update samples/backend/csharp/Controllers/ChatController.cs
25e080f 
Co-authored-by: Stephen Toub <[email protected]>
@glecaros @stephentoub
Update samples/backend/csharp/Controllers/ChatController.cs
a86fd99 
Co-authored-by: Stephen Toub <[email protected]>
@glecaros @stephentoub
Update samples/backend/csharp/Controllers/ChatController.cs
08fc211 
Co-authored-by: Stephen Toub <[email protected]>
@glecaros @stephentoub
Update samples/backend/csharp/Controllers/ChatController.cs
cb803e7 
Co-authored-by: Stephen Toub <[email protected]>
@glecaros @stephentoub
Update samples/backend/csharp/Controllers/ChatController.cs
0ec9ff4 
Co-authored-by: Stephen Toub <[email protected]>
@glecaros @stephentoub
Update samples/backend/csharp/Controllers/ChatController.cs
bfee9c6 
Co-authored-by: Stephen Toub <[email protected]>
@dependabot @glecaros
Bump System.Text.Json from 8.0.3 to 8.0.4 in /samples/backend/csharp (#…
51fb574 
…67)

Bumps System.Text.Json from 8.0.3 to 8.0.4.

---
updated-dependencies:
- dependency-name: System.Text.Json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@glecaros
Feedback
62cbe9c
@glecaros glecaros merged commit 83324eb into main Aug 13, 2024
2 checks passed
@glecaros glecaros deleted the glecaros/file_upload branch August 13, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@pamelafox pamelafox pamelafox approved these changes

@rohit-ganguly rohit-ganguly rohit-ganguly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glecaros @pamelafox @stephentoub @rohit-ganguly