Update spec and samples to jsonl MIME type #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glecaros
reviewed
Jun 28, 2024
rohit-ganguly
changed the title
glecaros
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #57
This pull request involves changes across several files, primarily aimed at transitioning from newline-delimited JSON (NDJSON) to JSON Lines (jsonl) format. This includes changes in the
Content-Typeheader in HTTP responses, modifications in import statements, and updates in the documentation.Changes related to
Content-Type:samples/backend/csharp/Controllers/ChatController.cs: TheContent-Typeheader in the HTTP response of theProcessStreamingMessagemethod has been changed fromapplication/x-ndjsontoapplication/jsonl.samples/backend/js/expressjs/src/routes/chat.ts: TheContent-Typeof the response in thechat.postmethod has been updated toapplication/jsonl.spec/models.tsp: ThecontentTypein theAIChatCompletionDeltamodel has been updated toapplication/jsonl.Changes related to import statements:
sdk/js/packages/client/src/client.ts: The import statement forgetAsyncIterablehas been changed to import from./util/jsonl.jsinstead of./util/ndjson.js.sdk/js/packages/client/test/util/ndjson.shared.test.ts: The import statement forgetAsyncIterablehas been updated to./util/jsonl.js.Changes in documentation:
spec/README.md: The documentation has been updated to reflect the change from NDJSON to jsonl in the HTTP response format andContent-Typeheader. [1] [2]