Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Improve Custom Agent Sample in AgentChat #5450

Closed
ekzhu opened this issue Feb 8, 2025 · 1 comment · Fixed by #5468
Closed

[Python] Improve Custom Agent Sample in AgentChat #5450

ekzhu opened this issue Feb 8, 2025 · 1 comment · Fixed by #5468
Assignees
@victordibia
Labels
documentation Improvements or additions to documentation proj-agentchat
Milestone
python-v0.4.x

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented Feb 8, 2025

One thing I am getting from this is that we probably need more COMPLETE examples of custom agents showing:

  • How to extend it to use custom model clients and participate in a groupchat
  • How to implement load/save state for serialization
  • How to implement component config such that it can work in AGS

We can do all of these today, we just need to show examples. our current custom agents example falls short in these things.

What other useful things should the example show?

Originally posted by @victordibia in #5441
@ekzhu ekzhu added documentation Improvements or additions to documentation proj-agentchat labels Feb 8, 2025
@ekzhu ekzhu added this to the python-v0.4.x milestone Feb 8, 2025
@ekzhu ekzhu mentioned this issue Feb 8, 2025
Open
@victordibia
Copy link
Collaborator

Thanks Eric @ekzhu.
I’ll take this on and ping you when I have something to review.

@victordibia victordibia self-assigned this Feb 8, 2025
@ekzhu ekzhu changed the title [Python] Improve Custom Client Sample in AgentChat [Python] Improve Custom Agent Sample in AgentChat Feb 8, 2025
victordibia added a commit that referenced this issue Feb 10, 2025
@victordibia
improve docs, add example of custom model clients with custom agents …
aa283a3 
…and serialization #5450
@victordibia victordibia mentioned this issue Feb 10, 2025
Merged
3 tasks
@ekzhu ekzhu closed this as completed in cd085e6 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victordibia victordibia

Labels
documentation Improvements or additions to documentation proj-agentchat
Projects
None yet
Milestone
python-v0.4.x
2 participants
@ekzhu @victordibia