Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gRPC Agent Runtime Serialization Registration #5513

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

lokitoth
Copy link
Member

We were registering the serializers when we already had a concrete type on the way into Publish or Send on the .NET side. However, in a xLang scenario, messages could originate from e.g. Python before being sent/published from .NET, resulting in no serializer being found.

This change adds a second-change registration and lookup when the agent is instantiated based on the IHandle implementations.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.50%. Comparing base (492b106) to head (51ed705).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Microsoft.AutoGen/Core.Grpc/GrpcAgentRuntime.cs 62.50% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5513      +/-   ##
==========================================
- Coverage   78.35%   76.50%   -1.85%     
==========================================
  Files         167      206      +39     
  Lines        9923    11037    +1114     
  Branches        0      150     +150     
==========================================
+ Hits         7775     8444     +669     
- Misses       2148     2496     +348     
- Partials        0       97      +97     
Flag Coverage Δ
unittests 76.50% <83.33%> (-1.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We were registering the serializers when we already had a concrete type on the way into Publish or Send on the .NET side. However, in a xLang scenario, messages could originate from e.g. Python before being sent/published from .NET, resulting in no serializer being found.

This change adds a second-change registration and lookup when the agent is instantiated based on the IHandle<T> implementations.
@lokitoth lokitoth force-pushed the dev/fix_dotnet_grpc_serialization branch from b73f877 to ff9ed4d Compare February 12, 2025 16:13
@lokitoth lokitoth merged commit 07fdc4e into main Feb 12, 2025
54 checks passed
@lokitoth lokitoth deleted the dev/fix_dotnet_grpc_serialization branch February 12, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants