fix: Make race condition between channel open and RPC less likely to occur #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
approved these changes
Feb 12, 2025
Right now we rely on opening the channel to associate a ClientId with an entry on the gateway side. This causes a race when the channel is being opened in the background while an RPC (e.g. MyAgent.register()) is invoked. If the RPC is processed first, the gateway rejects it due to "invalid" clientId.
lokitoth
force-pushed
the
dev/fix_grpcagentruntime_startup2
branch
from
62e9bea to
b324983
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5514 +/- ##
=======================================
Coverage 78.35% 78.35%
=======================================
Files 167 167
Lines 9923 9926 +3
=======================================
+ Hits 7775 7778 +3
Misses 2148 2148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lokitoth
force-pushed
the
dev/fix_grpcagentruntime_startup2
branch
from
b324983 to
5e0e0fb
Compare
lokitoth
force-pushed
the
dev/fix_grpcagentruntime_startup2
branch
from
8654e71 to
f3bb234
Compare
lokitoth
added a commit
that referenced
this pull request
Feb 13, 2025
…registration (#5521) This finishes the fix for the race condition between opening a GrpcWorkerConnection and registering agent types on that worker. Now, instead of failing to register, we return from the call (with the expectation that we will finish registration as we set up the connection) Part 1: #5494 Part 2: #5514 --------- Co-authored-by: Ryan Sweet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we rely on opening the channel to associate a ClientId with an entry on the gateway side. This causes a race when the channel is being opened in the background while an RPC (e.g. MyAgent.register()) is invoked.
If the RPC is processed first, the gateway rejects it due to "invalid" clientId.
This fix makes this condition less likely to trigger, but there is still a piece of the puzzle that needs to be solved on the Gateway side.